#28212 closed enhancement (duplicate)

Optimizing all_periodic_points() for small periods

Reported by: gh-Zopherus Owned by:
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: dynamics Keywords: SI2019, sd104
Cc: Merged in:
Authors: Eric Zhu, Alex Galarraga, Bianca Thompson Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: u/gh-Zopherus/28212 (Commits, GitHub, GitLab) Commit: 6b8b99c5ac78dacede53dffbc65a7340d70eb2f1
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-Zopherus)

Currently, the all_periodic_points() method uses an algorithm that reduces the function modulo p and checks for possible cycle lengths and lifts. This method may be slow in certain cases, such as x2 - 3/4, where we resort to calling the periodic_points() method which solves for the dynatomic polynomial.

Change History (8)

comment:1 Changed 21 months ago by gh-Zopherus

  • Description modified (diff)

comment:2 Changed 21 months ago by gh-Zopherus

  • Description modified (diff)

comment:3 Changed 21 months ago by gh-Zopherus

  • Branch set to u/gh-Zopherus/28212

comment:4 Changed 21 months ago by gh-Zopherus

  • Commit set to 6b8b99c5ac78dacede53dffbc65a7340d70eb2f1
  • Status changed from new to needs_review

Last 10 new commits:

8a46a0fMerge branch 'u/gh-Zopherus/28109' of git://trac.sagemath.org/sage into 28109
025c74aAdded method to cython helper
f20eadfMerge branch 'u/gh-Zopherus/28109' of git://trac.sagemath.org/sage into 28109
0f27e69added C code to all_periodic_points()
0682214Merge branch 'u/gh-Zopherus/28109' of git://trac.sagemath.org/sage into 28109
db9b233added documentation and deprecated rational_periodic_points
7b48f15Finished depreciation
81df710Added optional parameter for base ring
6862514delete print statement
6b8b99cAdded check to do dynatomic method

comment:5 Changed 21 months ago by gh-jasminecamero

This ticket depends on ticket #28109 so it needs to be added to dependencies.

comment:6 Changed 21 months ago by bhutz

  • Milestone changed from sage-8.9 to sage-duplicate/invalid/wontfix
  • Reviewers set to Ben Hutz

This optimization is already done in #28109 as part of the major overhaul of the periodic point functionality.

comment:7 Changed 17 months ago by bhutz

  • Keywords sd104 added
  • Status changed from needs_review to positive_review

comment:8 Changed 17 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.