Opened 3 years ago

Closed 3 years ago

#28210 closed defect (fixed)

py3 perfect_matching

Reported by: jhpalmieri Owned by:
Priority: major Milestone: sage-8.9
Component: python3 Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 363729d (Commits, GitHub, GitLab) Commit: 363729d10da5225f0f580afcf49e26fb84bf80b7
Dependencies: Stopgaps:

Status badges


Fix the py3 doctest failures in combinat/

Change History (4)

comment:1 Changed 3 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/perfect_matching

comment:2 Changed 3 years ago by jhpalmieri

  • Commit set to 363729d10da5225f0f580afcf49e26fb84bf80b7
  • Status changed from new to needs_review

I marked some doctests random, and then I added extra tests to make sure the output was still mathematically correct. This may be a bit of overkill, but at least the newly added stuff has all gone into TESTS blocks, so it should be hidden from casual users.

New commits:

363729dtrac 28210: fix the three py3 doctest failures in combinat/

comment:3 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, thx

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/jhpalmieri/perfect_matching to 363729d10da5225f0f580afcf49e26fb84bf80b7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.