Opened 3 years ago

Closed 3 years ago

#28196 closed enhancement (fixed)

remove some deprecated stuff in modular

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.9
Component: modular forms Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 22ec03d (Commits, GitHub, GitLab) Commit: 22ec03da3e7d8587b19fd1554b06941deaa918a0
Dependencies: Stopgaps:

Status badges

Change History (7)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/28196
  • Cc tscrim added
  • Commit set to 765c329ff22fb32ad3a2d593a9c178bf7f88e5dc
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

765c329remove some deprecated stuff in modular

comment:2 Changed 3 years ago by tscrim

  • Description modified (diff)
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 3 years ago by fbissey

The patchbot has this failing doctest and so do I

sage -t --long src/sage/modular/btquotients/pautomorphicform.py
**********************************************************************
File "src/sage/modular/btquotients/pautomorphicform.py", line 2336, in sage.modular.btquotients.pautomorphicform.pAdicAutomorphicForms.zero
Failed example:
    H1.zero_element() == 0
Exception raised:
    Traceback (most recent call last):
      File "/home/sage-patchbot/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 681, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/sage-patchbot/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1105, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.modular.btquotients.pautomorphicform.pAdicAutomorphicForms.zero[3]>", line 1, in <module>
        H1.zero_element() == Integer(0)
      File "sage/structure/category_object.pyx", line 834, in sage.structure.category_object.CategoryObject.__getattr__ (build/cythonized/sage/structure/category_object.c:6872)
        return self.getattr_from_category(name)
      File "sage/structure/category_object.pyx", line 849, in sage.structure.category_object.CategoryObject.getattr_from_category (build/cythonized/sage/structure/category_object.c:7035)
        attr = getattr_from_other_class(self, cls, name)
      File "sage/cpython/getattr.pyx", line 389, in sage.cpython.getattr.getattr_from_other_class (build/cythonized/sage/cpython/getattr.c:2547)
        raise AttributeError(dummy_error_message)
    AttributeError: 'pAdicAutomorphicForms_with_category' object has no attribute 'zero_element'
**********************************************************************

comment:4 Changed 3 years ago by chapoton

  • Status changed from positive_review to needs_work

comment:5 Changed 3 years ago by git

  • Commit changed from 765c329ff22fb32ad3a2d593a9c178bf7f88e5dc to 22ec03da3e7d8587b19fd1554b06941deaa918a0

Branch pushed to git repo; I updated commit sha1. New commits:

22ec03dtrac 28196 fix doctest

comment:6 Changed 3 years ago by chapoton

  • Status changed from needs_work to positive_review

Thank you. I fixed the doctest failure, and allow myself to set back to positive.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/28196 to 22ec03da3e7d8587b19fd1554b06941deaa918a0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.