Opened 3 years ago

Closed 3 years ago

#28192 closed enhancement (fixed)

more py3 passing folders

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.9
Component: python3 Keywords:
Cc: jdemeyer, tscrim, fbissey, embray, jhpalmieri, vklein Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: adce7a4 (Commits, GitHub, GitLab) Commit: adce7a45b4b7a4eecf70452f3f25d069715a662f
Dependencies: Stopgaps:

Status badges

Description

to keep them passing, with buildbots as gatekeepers

Change History (9)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/28192
  • Commit set to 8bd41e803e7c23e5a4b99b92ed3d9d64f2f74cfe
  • Status changed from new to needs_review

New commits:

8bd41e8more python3 passing folders

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

There are various failures, for sure the src/sage/doctest/tests contains test fixtures and isn't supposed to be tested individually.

sage -t --long src/sage/doctest/tests/atexit.rst  # 2 doctests failed
sage -t --long src/sage/doctest/tests/fail_and_die.rst  # Killed due to kill signal
sage -t --long src/sage/doctest/tests/initial.rst  # 5 doctests failed

comment:4 Changed 3 years ago by git

  • Commit changed from 8bd41e803e7c23e5a4b99b92ed3d9d64f2f74cfe to ef7233dbe9e50b3414d2906331fa39089453834a

Branch pushed to git repo; I updated commit sha1. New commits:

ef7233dfix

comment:5 Changed 3 years ago by tscrim

  • Status changed from needs_work to positive_review

comment:6 Changed 3 years ago by chapoton

  • Status changed from positive_review to needs_work

one moment, please. I am double checking

comment:7 Changed 3 years ago by git

  • Commit changed from ef7233dbe9e50b3414d2906331fa39089453834a to adce7a45b4b7a4eecf70452f3f25d069715a662f

Branch pushed to git repo; I updated commit sha1. New commits:

adce7a4exclude eclib (fails) and misc/notes (empty)

comment:8 Changed 3 years ago by chapoton

  • Status changed from needs_work to positive_review

ok, let us try again.

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/28192 to adce7a45b4b7a4eecf70452f3f25d069715a662f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.