Opened 6 months ago

Closed 6 months ago

#28178 closed defect (fixed)

get rid of ETupleIter

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.9
Component: algebra Keywords:
Cc: Merged in:
Authors: Vincent Delecroix Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 273cf12 (Commits) Commit: 273cf129af58929570cf20d641611c3a4d85892d
Dependencies: Stopgaps:

Description (last modified by vdelecroix)

ETuple used in exponents of generic multivariate polynomials implement their own iterator ETupleIter which is broken with respect to 

sage: from array import array
sage: R.<x,y,z> = QQ[]
sage: e = (x*y*z).exponents()[0]
sage: array('l', e)
Traceback (most recent call last):
...
TypeError: 'sage.rings.polynomial.polydict.ETupleIter' object is not iterable

Now that Cython is more modern than at the time this was implemented we get rid of this custom iterator.

Change History (7)

comment:1 Changed 6 months ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch set to u/vdelecroix/28178
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from implement __iter__ for ETupleIter to get rid of ETupleIter

comment:2 Changed 6 months ago by git

  • Commit set to d1e48b3bb0ad6682e5afc59e109b2e205c2f5b45

Branch pushed to git repo; I updated commit sha1. New commits:

​d1e48b328178: get rid of ETupleIter

comment:3 Changed 6 months ago by chapoton

  • Status changed from needs_review to needs_work

2 failing doctests, see patchbot report

comment:4 Changed 6 months ago by git

  • Commit changed from d1e48b3bb0ad6682e5afc59e109b2e205c2f5b45 to 273cf129af58929570cf20d641611c3a4d85892d

Branch pushed to git repo; I updated commit sha1. New commits:

​273cf1228178: fix length 1 ETuple string

comment:5 Changed 6 months ago by vdelecroix

  • Status changed from needs_work to needs_review

Indeed.

comment:6 Changed 6 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, lgtm

comment:7 Changed 6 months ago by vbraun

  • Branch changed from u/vdelecroix/28178 to 273cf129af58929570cf20d641611c3a4d85892d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.