Opened 20 months ago
Closed 20 months ago
#28177 closed defect (fixed)
py3 fix for combinat/finite_state.py
Reported by: | jhpalmieri | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.9 |
Component: | python3 | Keywords: | |
Cc: | chapoton, tscrim | Merged in: | |
Authors: | John Palmieri | Reviewers: | Vincent Klein |
Report Upstream: | N/A | Work issues: | |
Branch: | f2727fe (Commits, GitHub, GitLab) | Commit: | f2727fe480b22e48f202a92ca8892690d8b68165 |
Dependencies: | Stopgaps: |
Description
Some instances of frozenset
print in random order in Python 3 as compared to Python 2, so doctests can fail.
Change History (4)
comment:1 Changed 20 months ago by
- Branch set to u/jhpalmieri/py3-finite-state-machine
comment:2 Changed 20 months ago by
- Cc chapoton tscrim added
- Commit set to f2727fe480b22e48f202a92ca8892690d8b68165
- Status changed from new to needs_review
comment:3 Changed 20 months ago by
- Reviewers set to Vincent Klein
- Status changed from needs_review to positive_review
Looks good to me.
comment:4 Changed 20 months ago by
- Branch changed from u/jhpalmieri/py3-finite-state-machine to f2727fe480b22e48f202a92ca8892690d8b68165
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I believe that the doctest is supposed to demonstrate that the algorithm gives the same answer when run twice in a row, and this change preserves that.
New commits:
trac 28177: py3 doctest fix for finite_state_machine.py