Opened 3 years ago

Closed 3 years ago

#28167 closed enhancement (fixed)

Py3: Fix combinat.root_system.root_lattice_realisations doctests

Reported by: vklein Owned by:
Priority: major Milestone: sage-8.9
Component: python3 Keywords:
Cc: chapoton Merged in:
Authors: Vincent Klein Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 9d05aab (Commits, GitHub, GitLab) Commit: 9d05aab723480169a773a0dad1cfdb71af4e49b5
Dependencies: Stopgaps:

Status badges

Description (last modified by vklein)

Use #py2 #py3 doctests flags. The root cause is that RecursivelyEnumeratedSet_graded.breadth_first_search_iterator use a set which is not enumerated in the same order between py2 and py3. Look at #27967 for details.

Change History (6)

comment:1 Changed 3 years ago by vklein

  • Description modified (diff)

comment:2 Changed 3 years ago by vklein

  • Branch set to u/vklein/28167

comment:3 Changed 3 years ago by vklein

  • Authors set to Vincent Klein
  • Commit set to 9d05aab723480169a773a0dad1cfdb71af4e49b5

New commits:

9d05aabTrac #28167: Fix py3 root_lattice_realisations...

comment:4 Changed 3 years ago by vklein

  • Cc chapoton added
  • Status changed from new to needs_review

comment:5 Changed 3 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks okay to me.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/vklein/28167 to 9d05aab723480169a773a0dad1cfdb71af4e49b5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.