#28153 closed enhancement (fixed)

py3 fix and typos in combinatorial polyhedron

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.9
Component: python3 Keywords:
Cc: gh-kliem, tscrim, vdelecroix Merged in:
Authors: Frédéric Chapoton Reviewers: Jonathan Kliem, Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: f57bce1 (Commits, GitHub, GitLab) Commit: f57bce1ab1a4c96a9830b58e13cd2aebdb520545
Dependencies: Stopgaps:

Status badges

Change History (8)

comment:1 Changed 22 months ago by chapoton

  • Branch set to u/chapoton/28153
  • Commit set to f57bce1ab1a4c96a9830b58e13cd2aebdb520545
  • Status changed from new to needs_review

New commits:

f57bce1py3 fix and typos in combinatorial polyhedron

comment:2 Changed 22 months ago by gh-kliem

  • Reviewers set to Jonathan Kliem

Looks good to me, but I haven't pulled and tested it on a computer yet.

comment:3 Changed 22 months ago by chapoton

  • Cc tscrim vdelecroix added

comment:4 Changed 22 months ago by chapoton

green bot, please review

comment:5 Changed 22 months ago by dimpase

  • Description modified (diff)
  • Reviewers changed from Jonathan Kliem to Jonathan Kliem, Dima Pasechnik
  • Status changed from needs_review to positive_review

comment:6 Changed 22 months ago by chapoton

and there are many other typos in all this new stuff about combinatorial polyhedra...

comment:7 Changed 22 months ago by gh-kliem

I believe it. I find it hard to detect my own typos. It took be a while to find the mistakes corrected in this ticket (reading both lines I still couldn't detect mistakes for a while). I while correct, whatever I can.

comment:8 Changed 22 months ago by vbraun

  • Branch changed from u/chapoton/28153 to f57bce1ab1a4c96a9830b58e13cd2aebdb520545
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.