Opened 2 years ago

Closed 2 years ago

#28111 closed defect (fixed)

Insert missing newline in Morphism_abstract class

Reported by: gh-NicoCourts Owned by:
Priority: trivial Milestone: sage-8.9
Component: documentation Keywords: documentation
Cc: Merged in:
Authors: Nico Courts Reviewers: Kevin Lui
Report Upstream: N/A Work issues:
Branch: e37690c (Commits, GitHub, GitLab) Commit: e37690ce573705fd61eae675120b692a01fc8e53
Dependencies: Stopgaps:

Status badges

Description

There is a missing newline before "EXAMPLES:" in the class sage.modular.abvar.morphism.Morphism_abstract.

Change History (8)

comment:1 Changed 2 years ago by gh-NicoCourts

  • Branch set to u/gh-NicoCourts/insert_missing_newline_in_morphism_abstract_class

comment:2 Changed 2 years ago by gh-NicoCourts

  • Commit set to d72b47245c464e1e355ac2ae12ea1b86993f647c
  • Status changed from new to needs_review

New commits:

d72b472Insert missing newline to morphism.py

comment:3 Changed 2 years ago by klui

  • Reviewers set to Kevin Lui
  • Status changed from needs_review to positive_review

Looks good to me!

comment:4 Changed 2 years ago by klui

  • Status changed from positive_review to needs_work

Actually, could you get rid of the trailing whitespace on L53 and the whitespace on L54?

comment:5 Changed 2 years ago by git

  • Commit changed from d72b47245c464e1e355ac2ae12ea1b86993f647c to e37690ce573705fd61eae675120b692a01fc8e53

Branch pushed to git repo; I updated commit sha1. New commits:

e37690cRemove unwanted whitespace as requested

comment:6 Changed 2 years ago by gh-NicoCourts

  • Status changed from needs_work to needs_review

Made requested changes! :)

comment:7 Changed 2 years ago by klui

  • Status changed from needs_review to positive_review

Thanks! Looks good!

comment:8 Changed 2 years ago by vbraun

  • Branch changed from u/gh-NicoCourts/insert_missing_newline_in_morphism_abstract_class to e37690ce573705fd61eae675120b692a01fc8e53
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.