Opened 3 years ago

Closed 3 years ago

#28105 closed enhancement (fixed)

move some combinat references to master bibliographic file

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.9
Component: documentation Keywords:
Cc: embray, jhpalmieri, tscrim Merged in:
Authors: Frédéric Chapoton, John Palmieri Reviewers: John Palmieri, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 68807e5 (Commits, GitHub, GitLab) Commit: 68807e53b5537d1a05328d812ef9fd5911288248
Dependencies: Stopgaps:

Status badges

Description

extracted from #27692

Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/28105
  • Commit set to 04a51c4e410660b4a1e625f5cb72a641e5704a97

New commits:

​04a51c4move some combinat references to master reference file

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 3 years ago by jhpalmieri

  • Branch changed from u/chapoton/28105 to u/jhpalmieri/28105

comment:4 Changed 3 years ago by jhpalmieri

  • Commit changed from 04a51c4e410660b4a1e625f5cb72a641e5704a97 to 68807e53b5537d1a05328d812ef9fd5911288248
  • Reviewers set to John Palmieri
  • Status changed from new to needs_review

There was an indentation problem: not due to you, see ​http://doc.sagemath.org/html/en/reference/combinat/sage/combinat/fully_packed_loop.html and search for "more examples:". What follows is a long block was indented too much, so it is not highlighted properly. The REFERENCES section at the end is touched by your branch.

This ready for review, right? I'm happy with your branch, so set to positive if you approve of my changes.

New commits:

​68807e5trac 28105: fix an indentation problem

comment:5 Changed 3 years ago by chapoton

  • Authors set to Frédéric Chapoton, John Palmieri
  • Reviewers changed from John Palmieri to John Palmieri, Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, thanks. Good to go.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/jhpalmieri/28105 to 68807e53b5537d1a05328d812ef9fd5911288248
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.