#28058 closed enhancement (duplicate)

Reimplement dualRSK algorithm

Reported by: gh-ChamanAgrawal Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics Keywords: gsocRSK
Cc: tscrim, darij Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: u/gh-ChamanAgrawal/28058_dualRSK (Commits, GitHub, GitLab) Commit: 1bc9fb9c07d2eaf62e2b58f2c893b464fff9e938
Dependencies: Stopgaps:

Status badges

Description

To move the implementation of dualRSK from #25070 following the new RSK structure introduced in #27852 thereby finishing #25070.

Change History (8)

comment:1 Changed 22 months ago by gh-ChamanAgrawal

  • Branch set to u/gh-ChamanAgrawal/28058_dualRSK
  • Commit set to b467c1f40e56aa6f6216c6d322455eaeacace253
  • Status changed from new to needs_review

Last 10 new commits:

45869d9Minor documentation changes
cabc1ecAdd one-line doc and examples to functions
53ee04aAdd examples to functions
37d09deAdded simpler examples in RuleEG rev_insertion
8d339e0Merge branch 'u/gh-ChamanAgrawal/27852_refactorRSK' into start_dualRSK
6ced9c8Added documentation and tests for DualRSK
5313c0eChanged (rev)insertion() to single row operation
734ae02Moved rules' documentation into their class
a21d65fChange insertion function
b467c1fAdded documentation to dual RSK

comment:2 Changed 22 months ago by git

  • Commit changed from b467c1f40e56aa6f6216c6d322455eaeacace253 to 7246802eef84b5ec61046003d5b7e217d1f644ca

Branch pushed to git repo; I updated commit sha1. New commits:

d5bf7deChange insertion() to reduce passing parameters
9f208c9Merge branch 'u/gh-ChamanAgrawal/27852_refactorRSK' into u/gh-ChamanAgrawal/28058_dualRSK
7246802Removed extra parameter from insertion()

comment:3 Changed 22 months ago by git

  • Commit changed from 7246802eef84b5ec61046003d5b7e217d1f644ca to 89a749c4a3863a4ed2dac1bed88202f359e34a02

Branch pushed to git repo; I updated commit sha1. New commits:

5cc0008Minor changes in documentation
4ee1e35Remove insertion_complete for insertion()
02db216Merge branch 'u/gh-ChamanAgrawal/27852_refactorRSK' into u/gh-ChamanAgrawal/28058_dualRSK
89a749cMinor change in docs and insertion()

comment:4 Changed 22 months ago by git

  • Commit changed from 89a749c4a3863a4ed2dac1bed88202f359e34a02 to e03a2c9a3f5a0caf1532c3e2259c12b65e3e87ec

Branch pushed to git repo; I updated commit sha1. New commits:

f946493Add forgotten docs change
e4554eeDocs corrected
e03a2c9Merge branch 'u/gh-ChamanAgrawal/27852_refactorRSK' into u/gh-ChamanAgrawal/28058_dualRSK

comment:5 Changed 22 months ago by git

  • Commit changed from e03a2c9a3f5a0caf1532c3e2259c12b65e3e87ec to 1bc9fb9c07d2eaf62e2b58f2c893b464fff9e938

Branch pushed to git repo; I updated commit sha1. New commits:

1bc9fb9Resolved merge conflicts

comment:6 Changed 21 months ago by tscrim

  • Authors Chaman Agrawal deleted
  • Cc darij added
  • Milestone changed from sage-feature to sage-duplicate/invalid/wontfix
  • Reviewers set to Travis Scrimshaw

This was reviewed in #25070.

comment:7 Changed 20 months ago by tscrim

  • Status changed from needs_review to positive_review

comment:8 Changed 20 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.