Opened 3 years ago

Closed 2 years ago

#28045 closed enhancement (fixed)

spkg-configure.m4 for libatomic

Reported by: dimpase Owned by:
Priority: major Milestone: sage-9.1
Component: build: configure Keywords: spkg-configure
Cc: embray, mjo Merged in:
Authors: Michael Orlitzky Reviewers: Isuru Fernando
Report Upstream: N/A Work issues:
Branch: e86ec71 (Commits, GitHub, GitLab) Commit: e86ec713a996be9f58eb81d32c21293ac37e1b7b
Dependencies: Stopgaps:

Status badges

Description

this might need a tricky (?) check that the configuration is as needed for ecl.

otherwise, libatomic has no deps, and gc only depends on libatomic

Change History (7)

comment:1 Changed 2 years ago by embray

  • Milestone changed from sage-8.9 to sage-9.1

Ticket retargeted after milestone closed

comment:2 Changed 2 years ago by mjo

  • Branch set to u/mjo/ticket/28045
  • Cc mjo added
  • Commit set to e86ec713a996be9f58eb81d32c21293ac37e1b7b

Should we do these separately? If gc winds up being tricky, we can do the dead-simple libatomic in the meantime.

comment:3 Changed 2 years ago by mjo

  • Status changed from new to needs_review
  • Summary changed from spkg-configure.m4 for gc and libatomic to spkg-configure.m4 for libatomic

Let's do libatomic here, and gc in #28991. I'd like to get the easy ones out of the way and then we can spent as much time as it takes to do the tricky ones.

comment:4 Changed 2 years ago by isuruf

  • Reviewers set to Isuru Fernando
  • Status changed from needs_review to positive_review

Works for me. gc finds it. checking which libatomic_ops to use... external

comment:5 Changed 2 years ago by chapoton

add missing Author full name, please

comment:6 Changed 2 years ago by mjo

  • Authors set to Michael Orlitzky

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/mjo/ticket/28045 to e86ec713a996be9f58eb81d32c21293ac37e1b7b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.