Opened 4 years ago

Closed 3 years ago

#28023 closed enhancement (fixed)

matplotlib 2.2.4 + patches

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-8.9
Component: packages: standard Keywords:
Cc: Timo Kaufmann Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: 296092e (Commits, GitHub, GitLab) Commit: 296092eedf7bf082e9b4d777fbdf17c223f3a7a5
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Upgrade to matplotlib 2.2.4

Tarball: ​http://sage.ugent.be/www/jdemeyer/sage/matplotlib-2.2.4.tar.bz2

We add two patches:

Change History (14)

comment:1 Changed 4 years ago by Jeroen Demeyer

Description: modified (diff)

comment:2 Changed 4 years ago by Jeroen Demeyer

Description: modified (diff)

comment:3 Changed 4 years ago by Jeroen Demeyer

Branch: → u/jdemeyer/t/28023

comment:4 Changed 4 years ago by git

Commit: → 175a0341ff3435fe453ff4fae9cb8b3261828008

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​175a034matplotlib 2.2.4

comment:5 Changed 4 years ago by git

Commit: 175a0341ff3435fe453ff4fae9cb8b3261828008 → 296092eedf7bf082e9b4d777fbdf17c223f3a7a5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​296092ematplotlib 2.2.4

comment:6 Changed 4 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: matplotlib 2.2.4 + setup.py patch → matplotlib 2.2.4 + patches

comment:7 Changed 4 years ago by Jeroen Demeyer

Status: new → needs_review

comment:8 Changed 4 years ago by Timo Kaufmann

Cc: Timo Kaufmann added

comment:9 Changed 4 years ago by Jeroen Demeyer

Both patches affect only the build, so should be OK for distros.

comment:10 Changed 4 years ago by vklein

Saying this ticket apply ​PR#14582 is inaccurate because there is only one of the two commits of this PR in python38.patch. ​4b957fd is present but not ​d94433. Is it intended ?

comment:11 Changed 4 years ago by vklein

Tests pass with py3 for the sage files using matplolib. sage -t -a --long in progress for py2.

comment:12 Changed 4 years ago by vklein

All tests pass in py2.

comment:13 Changed 4 years ago by vklein

Reviewers: → Vincent Klein
Status: needs_review → positive_review

Since ​d94433 has nothing to do with python3.8 compatibility i set this ticket to positive review.

comment:14 Changed 3 years ago by Volker Braun

Branch: u/jdemeyer/t/28023 → 296092eedf7bf082e9b4d777fbdf17c223f3a7a5
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.