#28002 closed defect (fixed)
py3: last test in tests/cmdline.py
Reported by: | jhpalmieri | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.9 |
Component: | python3 | Keywords: | |
Cc: | Merged in: | ||
Authors: | John Palmieri | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | 8712a2f (Commits, GitHub, GitLab) | Commit: | 8712a2fab3fbab9944a4a08fc670515bd0b39ff2 |
Dependencies: | Stopgaps: |
Description
The fix is to ignore deprecation warnings about collections.abc
. This already done in src/sage/all.py
. At some point, this should be fixed throughout the Sage library, but that's for another ticket.
Change History (10)
comment:1 Changed 2 years ago by
- Branch set to u/jhpalmieri/cmdline-py3
comment:2 Changed 2 years ago by
- Commit set to 8712a2fab3fbab9944a4a08fc670515bd0b39ff2
- Status changed from new to needs_review
comment:3 Changed 2 years ago by
Regarding imports of collections.abc
and the deprecation warning: it seems to come as much from places like matplotlib
than from the actual Sage library. So maybe the problem will get fixed as we update the various Sage packages.
comment:4 Changed 2 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
ok, thx. Is there a way to make sure that sage itself is not responsible for any of these warnings ?
comment:5 Changed 2 years ago by
Both
grep -R "import collections.*abc" src/sage src/sage_setup src/doc
and
grep -R "from collections.*import.*abc" src/sage src/sage_setup src/doc
come up empty. I tried turning off the warnings in src/sage/all.py
, and when I ran a few doctests, I got a warning from matplotlib
. I don't know what else to try to do to check.
comment:6 follow-up: ↓ 7 Changed 2 years ago by
Ok, then we will see later when we upgrade matplotlib.
By the way, do you know "git grep" ? Useful tool, in my opinion. Only search in the files under git control.
comment:7 in reply to: ↑ 6 Changed 2 years ago by
Replying to chapoton:
Ok, then we will see later when we upgrade matplotlib.
By the way, do you know "git grep" ? Useful tool, in my opinion. Only search in the files under git control.
No, I didn't know, thanks for pointing it out.
comment:8 Changed 2 years ago by
See also #28012.
comment:9 Changed 2 years ago by
- Branch changed from u/jhpalmieri/cmdline-py3 to 8712a2fab3fbab9944a4a08fc670515bd0b39ff2
- Resolution set to fixed
- Status changed from positive_review to closed
comment:10 Changed 2 years ago by
- Milestone changed from sage-8.8 to sage-8.9
Not in Sage 8.8. Let's please to try keep tickets' milestones related to the release in which we actually intend to include them, and in particular the release in which they were actually included, especially when closing tickets.
New commits:
trac 28002: in sage-startuptime.py, ignore collections.abc deprecation