Opened 3 years ago
Last modified 3 years ago
#27987 closed defect
CombinatorialPolyhedron improve initialization, remove bug for unbounded polyhedra — at Version 12
Reported by:  ghkliem  Owned by:  

Priority:  major  Milestone:  sage8.9 
Component:  geometry  Keywords:  
Cc:  JeanPhilippe Labbé, Travis Scrimshaw, Vincent Delecroix  Merged in:  
Authors:  Jonathan Kliem  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  public/27987new (Commits, GitHub, GitLab)  Commit:  14d17a87bb48e32c98083b974e9cebd033390d80 
Dependencies:  #26887  Stopgaps: 
Description (last modified by )
CombinatorialPolyhedron
at the moment only requires the number of lines (as n_lines
in Polyhedron_base
). This does not suffice, as
sage: P1 = Polyhedron(vertices=[[0,1],[1,0]], rays=[[1,1]]) sage: P2 = Polyhedron(vertices=[[0,1],[1,0],[1,1]]) sage: P1.incidence_matrix() == P2.incidence_matrix() True
Instead of just specifying the n_lines
, one should specify unbounded
and a far face.
Unfortunately, determining the rays from just the incidence matrix does not seem to work.
Now with the far face at hand anyway, it's much easier to determine the (combinatorial) vertices.
Change History (12)
comment:1 Changed 3 years ago by
Summary:  `CombinatorialPolyhedron` improve initialization, remove bug for unbounded polyhedra → CombinatorialPolyhedron improve initialization, remove bug for unbounded polyhedra 

comment:2 Changed 3 years ago by
Branch:  → public/27987 

Commit:  → 39810e5194daea168c01f21b8f8efaeb24f5bf15 
comment:3 Changed 3 years ago by
Milestone:  sage8.8 

As the Sage8.8 release milestone is pending, we should delete the sage8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage8.9).
comment:4 Changed 3 years ago by
Milestone:  → sage8.9 

comment:5 Changed 3 years ago by
There is also a python3 failing doctest:
This triggers a new failing doctest with python3sage:
sage t long src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx ********************************************************************** File "src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx", line 937, in sage.geometry.polyhedron.combinatorial_polyhedron.base.CombinatorialPolyhedron.edge_graph Failed example: G.degree() Expected: [4, 3, 4, 3, 4] Got: [3, 4, 4, 3, 4]
comment:7 Changed 3 years ago by
Branch:  public/27987 → public/27987new 

Commit:  39810e5194daea168c01f21b8f8efaeb24f5bf15 → cdc1522e98cf0e17e88cb3fe0c4515f6e7925a51 
New commits:
cdc1522  combinatorial polyhedron uses far face as a bug fix

comment:8 Changed 3 years ago by
Commit:  cdc1522e98cf0e17e88cb3fe0c4515f6e7925a51 → c2f175d6691caa21a03495844a621f468e1b5bfc 

Branch pushed to git repo; I updated commit sha1. New commits:
c2f175d  small changes

comment:9 Changed 3 years ago by
Commit:  c2f175d6691caa21a03495844a621f468e1b5bfc → b90d25335cb2ac2ec91b08ed3b38993ffc60012d 

Branch pushed to git repo; I updated commit sha1. New commits:
b90d253  more small changes

comment:10 Changed 3 years ago by
Commit:  b90d25335cb2ac2ec91b08ed3b38993ffc60012d → d6d663a56310c63283adc279e79ec4eb2e983581 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
d6d663a  combinatorial polyhedron uses far face as a bug fix

comment:11 Changed 3 years ago by
Commit:  d6d663a56310c63283adc279e79ec4eb2e983581 → 14d17a87bb48e32c98083b974e9cebd033390d80 

Branch pushed to git repo; I updated commit sha1. New commits:
14d17a8  added doctest reporting the bug fix

comment:12 Changed 3 years ago by
Description:  modified (diff) 

Status:  new → needs_review 
New commits:
14d17a8  added doctest reporting the bug fix

Last 10 new commits:
added documentation and examples to each module
correct hyperlinks
documentation fix
Do not iterate twice for CombinatorialPolyhedron.facets()
added combinatorial face
improved docstring in list_of_all_faces
fixed small issues
A number of small edits.
Merge branch 'public/26887' of git://trac.sagemath.org/sage into develop
changed input of combintorial polyhedron