Opened 3 years ago

Closed 3 years ago

#27985 closed enhancement (fixed)

Make dynatomic polynomial coerce base ring

Reported by: gh-HTalbott Owned by:
Priority: minor Milestone: sage-8.9
Component: dynamics Keywords: SI2019
Cc: Ben Hutz, Mark Saaltink Merged in:
Authors: Henry Talbott Reviewers: Colby Kelln, Alex Shearer, Wayne Peng, Fiona Lu, Eric Zhu, Anna Chlopecki
Report Upstream: N/A Work issues:
Branch: edafd35 (Commits, GitHub, GitLab) Commit: edafd35e391834cef0d3d5d563d4d735903636f4
Dependencies: Stopgaps:

Status badges

Description (last modified by Samuel Lelièvre)

This ticket makes the following work:

sage: R.<c> = QQ[]
sage: Pc.<x, y> = ProjectiveSpace(R, 1)
sage: f = DynamicalSystem([xˆ2 + c*yˆ2, yˆ2], domain=Pc)
sage: k = FractionField(f.base_ring())
sage: new_fixed = 2
sage: m = matrix(k, 2, 2, [(new_fixed - 1)/new_fixed, 0, -1/new_fixed, 1])
sage: F = f.conjugate(m)
sage: F.dehomogenize(1).dynatomic_polynomial(2)

by making the dynatomic_polynomial function coerce to the correct base ring.

Change History (15)

comment:1 Changed 3 years ago by Adam Towsley

Component: PLEASE CHANGEdynamics

comment:2 Changed 3 years ago by gh-HTalbott

Branch: u/gh-HTalbott/27985

comment:3 Changed 3 years ago by gh-HTalbott

Commit: fa912d45e34e7c413bec0fffc13c154f483ab260
Description: modified (diff)
Status: newneeds_review

New commits:

fa912d4Fixed dynatomic polynomial function to coerce correct field

comment:4 Changed 3 years ago by git

Commit: fa912d45e34e7c413bec0fffc13c154f483ab260a59231a5dbed341995408f814503ecd5992e7e59

Branch pushed to git repo; I updated commit sha1. New commits:

a59231a27985: Dynatomic polynomial base field coercion

comment:5 Changed 3 years ago by Samuel Lelièvre

Description: modified (diff)
Summary: Dynatomic polynomial fails to coerce base ringMake dynatomic polynomial coerce base ring

comment:6 Changed 3 years ago by Ben Hutz

Milestone: sage-8.8sage-8.9

comment:7 Changed 3 years ago by Adam Towsley

Branch: u/gh-HTalbott/27985u/atowsley/27985

comment:8 Changed 3 years ago by Adam Towsley

Commit: a59231a5dbed341995408f814503ecd5992e7e595b2a99e6d53e13a3158a1fac7fff5bbc78f8afa2

Updated the branch since we were finally able to identify the root problem and fix it.


New commits:

5b2a99eUpdated inverse_of_unit in multi_polynomial_element

comment:9 Changed 3 years ago by Adam Towsley

Cc: Ben Hutz Mark Saaltink added

comment:10 Changed 3 years ago by Ben Hutz

You'll need documentation on that function before it can be marked positive, but we can test functionality.

comment:11 Changed 3 years ago by git

Commit: 5b2a99e6d53e13a3158a1fac7fff5bbc78f8afa2edafd35e391834cef0d3d5d563d4d735903636f4

Branch pushed to git repo; I updated commit sha1. New commits:

edafd35Added new documentation.

comment:12 Changed 3 years ago by Adam Towsley

The documentation is there now. It just needs review.

comment:13 Changed 3 years ago by gh-ckelln

Reviewers: Colby Kelln, Alex Shearer, Wayne Peng, Fiona Lu
Status: needs_reviewpositive_review

comment:14 Changed 3 years ago by Eric Zhu

Reviewers: Colby Kelln, Alex Shearer, Wayne Peng, Fiona LuColby Kelln, Alex Shearer, Wayne Peng, Fiona Lu, Eric Zhu, Anna Chlopecki

comment:15 Changed 3 years ago by Volker Braun

Branch: u/atowsley/27985edafd35e391834cef0d3d5d563d4d735903636f4
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.