Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#27970 closed defect (fixed)

libgd compiled with vpx support can has matrix_mod2_dense to fail to load, lah

Reported by: embray Owned by:
Priority: critical Milestone: sage-8.9
Component: porting: Cygwin Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: cec95ac (Commits, GitHub, GitLab) Commit: cec95ace7ebf8339940a500e07b4d1066624af39
Dependencies: Stopgaps:

Status badges

Description

There is a problem in the Cygwin package repository where there is a version of the libvpx package that is compiled against a newer version of the Cygwin DLL than is properly set in its dependencies.

The result is that if the libvpx-devel system package is installed, when compiling libgd it will enable vpx support but that doesn't actually work, and actually causes any DLLs linked to libgd (i.e. sage.matrix.matrix_mod2_dense) to fail to load.

Change History (8)

comment:1 Changed 3 years ago by embray

  • Branch set to u/embray/cygwin/build/issue-27901
  • Commit set to cec95ace7ebf8339940a500e07b4d1066624af39
  • Status changed from new to needs_review

New commits:

​cec95acTrac #27970: Disable vpx support when building libgd for Cygwin

comment:2 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

LGTM

comment:3 Changed 3 years ago by embray

Thanks!

comment:4 Changed 3 years ago by dimpase

  • Summary changed from libgd compiled with vpx support can matrix_mod2_dense to fail to load to libgd compiled with vpx support can has matrix_mod2_dense to fail to load, lah

comment:5 Changed 3 years ago by embray

lah?

comment:6 Changed 3 years ago by dimpase

Singlish, lah!

Last edited 3 years ago by dimpase (previous) (diff)

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/embray/cygwin/build/issue-27901 to cec95ace7ebf8339940a500e07b4d1066624af39
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 3 years ago by embray

  • Milestone changed from sage-8.8 to sage-8.9

Not in Sage 8.8. Let's please to try keep tickets' milestones related to the release in which we actually intend to include them, and in particular the release in which they were actually included, especially when closing tickets.

Note: See TracTickets for help on using tickets.