Changes between Initial Version and Version 1 of Ticket #27967, comment 37


Ignore:
Timestamp:
08/28/19 18:39:15 (2 years ago)
Author:
gh-mwageringel
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #27967, comment 37

    initial v1  
    22> I don't have strong feelings either way, but I would very much like to get this resolved. Is the old branch good enough?
    33
    4 No – to be more precise, my critique is just about commit `9c19a38` introducing the use of `OrderedDict`. All the other changes on the current branch look good to me and I will review them positively. The remaining doctest failures are not caused by `OrderedDict` specifically, but by the change in iteration order in general, so should still be fixed:
     4No – to be more precise, my criticism is just about commit `9c19a38` introducing the use of `OrderedDict`. All the other changes on the current branch look good to me and I will review them positively. The remaining doctest failures are not caused by `OrderedDict` specifically, but by the change in iteration order in general, so should still be fixed:
    55{{{
    66sage/categories/coxeter_groups.py