Changes between Initial Version and Version 1 of Ticket #27967, comment 37
- Timestamp:
- 08/28/19 18:39:15 (20 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #27967, comment 37
initial v1 2 2 > I don't have strong feelings either way, but I would very much like to get this resolved. Is the old branch good enough? 3 3 4 No – to be more precise, my criti queis just about commit `9c19a38` introducing the use of `OrderedDict`. All the other changes on the current branch look good to me and I will review them positively. The remaining doctest failures are not caused by `OrderedDict` specifically, but by the change in iteration order in general, so should still be fixed:4 No – to be more precise, my criticism is just about commit `9c19a38` introducing the use of `OrderedDict`. All the other changes on the current branch look good to me and I will review them positively. The remaining doctest failures are not caused by `OrderedDict` specifically, but by the change in iteration order in general, so should still be fixed: 5 5 {{{ 6 6 sage/categories/coxeter_groups.py