Opened 4 months ago

Closed 4 months ago

#27888 closed enhancement (fixed)

py3 fix for src/sage/all.py

Reported by: jhpalmieri Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 8c038b9 (Commits) Commit: 8c038b9fec021258426a9325b33a11dfe1caaf51
Dependencies: Stopgaps:

Description (last modified by jhpalmieri)

Fix doctest in src/sage/all.py, which currently fails sporadically with Python 3.

Change History (6)

comment:1 Changed 4 months ago by jhpalmieri

  • Branch set to u/jhpalmieri/all-env-py3

comment:2 Changed 4 months ago by git

  • Commit set to 584fbcc28e01b5e7225b51c938c324daeafeb51b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

584fbcctrac 27888: py3 fixes for top-level all.py, env.py

comment:3 Changed 4 months ago by jhpalmieri

  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from py3 fixes for src/sage/all.py, src/sage/env.py to py3 fix for src/sage/all.py

comment:4 Changed 4 months ago by git

  • Commit changed from 584fbcc28e01b5e7225b51c938c324daeafeb51b to 8c038b9fec021258426a9325b33a11dfe1caaf51

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8c038b9trac 27888: py3 fix for top-level all.py

comment:5 Changed 4 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

Well, looks good enough.

comment:6 Changed 4 months ago by vbraun

  • Branch changed from u/jhpalmieri/all-env-py3 to 8c038b9fec021258426a9325b33a11dfe1caaf51
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.