Opened 3 years ago

Closed 3 years ago

#27872 closed defect (fixed)

2 failing trivial internet doctests related to oeis

Reported by: slabbe Owned by:
Priority: major Milestone: sage-8.8
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Sébastien Labbé Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: af3a357 (Commits, GitHub, GitLab) Commit: af3a357aad0717a3895f47ddeb07f9a2a300f2a7
Dependencies: Stopgaps:

Status badges

Description

With 8.8.beta6, the command

sage -tp --long --optional=sage,internet src/sage/databases/oeis.py  src/sage/combinat/species/library.py

gives

sage -t --long src/sage/databases/oeis.py
**********************************************************************
File "src/sage/databases/oeis.py", line 1747, in sage.databases.oeis.OEISSequence.programs
Failed example:
    ee.programs()[0]                      # optional -- internet
Expected:
    '(PARI) { default(realprecision, 50080); x=exp(1); for (n=1, 50000, d=floor(x); x=(x-d)*10; write("b001113.txt", n, " ", d)); } \\\\ _Harry J. Smith_, Apr 15 2009'
Got:
    '(PARI) default(realprecision, 50080); x=exp(1); for (n=1, 50000, d=floor(x); x=(x-d)*10; write("b001113.txt", n, " ", d)); \\\\ _Harry J. Smith_, Apr 15 2009'
**********************************************************************
1 item had failures:
   1 of   7 in sage.databases.oeis.OEISSequence.programs
    5 webbrowser tests not run
    0 tests not run because we ran out of time
    [266 tests, 1 failure, 65.86 s]



sage -t --long src/sage/combinat/species/library.py
**********************************************************************
File "src/sage/combinat/species/library.py", line 64, in sage.combinat.species.library.SimpleGraphSpecies
Failed example:
    oeis(seq)[0]                              # optional -- internet
Expected:
    A006125: a(n) = 2^(n(n-1)/2).
Got:
    A006125: a(n) = 2^(n*(n-1)/2).
**********************************************************************
1 item had failures:
   1 of   9 in sage.combinat.species.library.SimpleGraphSpecies
    0 tests not run because we ran out of time
    [23 tests, 1 failure, 5.82 s]

Change History (5)

comment:1 Changed 3 years ago by slabbe

  • Authors set to Sébastien Labbé
  • Branch set to u/slabbe/27872
  • Commit set to af3a357aad0717a3895f47ddeb07f9a2a300f2a7
  • Status changed from new to needs_review

New commits:

af3a35727872: fixing oeis related doctests

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

LGTM.

comment:3 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:4 Changed 3 years ago by chapoton

This should really be made rock-solid, so that we do not have to come back and fix doctests at every single release..

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/slabbe/27872 to af3a357aad0717a3895f47ddeb07f9a2a300f2a7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.