Opened 4 years ago

Closed 3 years ago

#27871 closed enhancement (fixed)

some doc details in projective_curve

Reported by: Frédéric Chapoton Owned by:
Priority: trivial Milestone: sage-8.8
Component: algebraic geometry Keywords:
Cc: Travis Scrimshaw Merged in:
Authors: Frédéric Chapoton Reviewers: Thierry Monteil
Report Upstream: N/A Work issues:
Branch: 4edeb00 (Commits, GitHub, GitLab) Commit: 4edeb005089a85c4868d15ae04eebf81f4f27533
Dependencies: Stopgaps:

Status badges

Description


Change History (10)

comment:1 Changed 4 years ago by Frédéric Chapoton

Branch: u/chapoton/27871
Commit: 52c3f5cc63e90d6f20b85f03fa0b28d367ec8ba6
Status: newneeds_review

New commits:

52c3f5csome doc details in projective_curve.py

comment:2 Changed 4 years ago by git

Commit: 52c3f5cc63e90d6f20b85f03fa0b28d367ec8ba66fe9bc715284b9dd45b2a1e76b6c5a9968963ba1

Branch pushed to git repo; I updated commit sha1. New commits:

6fe9bc7trac 27871 fix

comment:3 Changed 4 years ago by Frédéric Chapoton

Cc: Travis Scrimshaw added

green bot, please review

comment:4 Changed 4 years ago by Thierry Monteil

Reviewers: Thierry Monteil
Status: needs_reviewpositive_review

LGTM.

comment:5 Changed 4 years ago by Nils Bruin

Status: positive_reviewneeds_work

If you're going to touch up documentation, at least fix grammatical mistakes as well: are worst that others -> are worse than others

comment:6 Changed 4 years ago by git

Commit: 6fe9bc715284b9dd45b2a1e76b6c5a9968963ba1d529710b277d8fb08f87c266fff5ef9d456ba64a

Branch pushed to git repo; I updated commit sha1. New commits:

d529710fix worse

comment:7 Changed 4 years ago by Frédéric Chapoton

Status: needs_workpositive_review

Please note that it is not good practice to undo some positive review, unless there are very good reasons for that.

I allow myself to set back the ticket to positive.

comment:8 Changed 4 years ago by git

Commit: d529710b277d8fb08f87c266fff5ef9d456ba64a4edeb005089a85c4868d15ae04eebf81f4f27533
Status: positive_reviewneeds_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

4edeb00some doc details in projective_curve.py

comment:9 Changed 4 years ago by Frédéric Chapoton

Status: needs_reviewpositive_review

comment:10 Changed 3 years ago by Volker Braun

Branch: u/chapoton/278714edeb005089a85c4868d15ae04eebf81f4f27533
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.