Opened 2 years ago

Closed 2 years ago

#27871 closed enhancement (fixed)

some doc details in projective_curve

Reported by: chapoton Owned by:
Priority: trivial Milestone: sage-8.8
Component: algebraic geometry Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Thierry Monteil
Report Upstream: N/A Work issues:
Branch: 4edeb00 (Commits, GitHub, GitLab) Commit: 4edeb005089a85c4868d15ae04eebf81f4f27533
Dependencies: Stopgaps:

Status badges

Description


Change History (10)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/27871
  • Commit set to 52c3f5cc63e90d6f20b85f03fa0b28d367ec8ba6
  • Status changed from new to needs_review

New commits:

52c3f5csome doc details in projective_curve.py

comment:2 Changed 2 years ago by git

  • Commit changed from 52c3f5cc63e90d6f20b85f03fa0b28d367ec8ba6 to 6fe9bc715284b9dd45b2a1e76b6c5a9968963ba1

Branch pushed to git repo; I updated commit sha1. New commits:

6fe9bc7trac 27871 fix

comment:3 Changed 2 years ago by chapoton

  • Cc tscrim added

green bot, please review

comment:4 Changed 2 years ago by tmonteil

  • Reviewers set to Thierry Monteil
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 2 years ago by nbruin

  • Status changed from positive_review to needs_work

If you're going to touch up documentation, at least fix grammatical mistakes as well: are worst that others -> are worse than others

comment:6 Changed 2 years ago by git

  • Commit changed from 6fe9bc715284b9dd45b2a1e76b6c5a9968963ba1 to d529710b277d8fb08f87c266fff5ef9d456ba64a

Branch pushed to git repo; I updated commit sha1. New commits:

d529710fix worse

comment:7 Changed 2 years ago by chapoton

  • Status changed from needs_work to positive_review

Please note that it is not good practice to undo some positive review, unless there are very good reasons for that.

I allow myself to set back the ticket to positive.

comment:8 Changed 2 years ago by git

  • Commit changed from d529710b277d8fb08f87c266fff5ef9d456ba64a to 4edeb005089a85c4868d15ae04eebf81f4f27533
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

4edeb00some doc details in projective_curve.py

comment:9 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

comment:10 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/27871 to 4edeb005089a85c4868d15ae04eebf81f4f27533
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.