Opened 6 months ago

Closed 6 months ago

#27868 closed enhancement (fixed)

py3: last fix in valuation

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b84c4d0 (Commits) Commit: b84c4d0b4b03d0789bc3dabe0fed73a9c2dec869
Dependencies: Stopgaps:

Description

by sorting

Change History (6)

comment:1 Changed 6 months ago by chapoton

  • Branch set to u/chapoton/27868
  • Commit set to 02e287df475cdf68c93b799ad5f2ae79c5a2cb34
  • Status changed from new to needs_review

New commits:

​02e287dpy3: fix in valuation

comment:2 Changed 6 months ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

You have now introduced a discrepancy in the docstring ``V1[0]``. Once fixed, you can set a positive review on my behalf.

comment:4 Changed 6 months ago by git

  • Commit changed from 02e287df475cdf68c93b799ad5f2ae79c5a2cb34 to b84c4d0b4b03d0789bc3dabe0fed73a9c2dec869

Branch pushed to git repo; I updated commit sha1. New commits:

​b84c4d0trac 27868 fix the doc

comment:5 Changed 6 months ago by chapoton

  • Status changed from needs_review to positive_review

thx, done. I am setting to positive.

comment:6 Changed 6 months ago by vbraun

  • Branch changed from u/chapoton/27868 to b84c4d0b4b03d0789bc3dabe0fed73a9c2dec869
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.