#27867 closed enhancement (fixed)

three more folders in python3-known-passing.txt

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: embray, jdemeyer, fbissey, tscrim, jhpalmieri Merged in:
Authors: Frédéric Chapoton Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 697a1b9 (Commits) Commit: 697a1b9834fac269fb7317ded9b8984238e67990
Dependencies: Stopgaps:

Description

to lock the progress towards python3

Change History (8)

comment:1 Changed 11 months ago by chapoton

  • Branch set to u/chapoton/27867
  • Commit set to 242226f737a195c96f7c2d755c1372a1fb3fef5c
  • Status changed from new to needs_review

New commits:

242226fthree more python3-compatible folders

comment:2 Changed 11 months ago by jhpalmieri

I get occasional failures in dynamics — this one about half the time:

sage -t src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py
**********************************************************************
File "src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py", line 1456, in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphisms_fixing_pair
Failed example:
    automorphisms_fixing_pair(f, L, False)
Expected:
    [(6*z + 6)/z, 6/(z + 1)]
Got:
    [6/(z + 1), (6*z + 6)/z]
**********************************************************************
1 item had failures:
   1 of   6 in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphisms_fixing_pair
    [114 tests, 1 failure, 1.04 s]

and this one once out of ten tries:

sage -t src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py
**********************************************************************
File "src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py", line 638, in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphism_group_QQ_CRT
Failed example:
    automorphism_group_QQ_CRT(f, 4, True)
Expected:
    [z, -z, 1/z, -1/z, (-z + 1)/(z + 1), (z + 1)/(z - 1), (z - 1)/(z + 1),
    (-z - 1)/(z - 1)]
Got:
    [z,
     -z,
     1/z,
     -1/z,
     (-z + 1)/(z + 1),
     (z + 1)/(z - 1),
     (-z - 1)/(z - 1),
     (z - 1)/(z + 1)]
**********************************************************************
File "src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py", line 647, in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphism_group_QQ_CRT
Failed example:
    automorphism_group_QQ_CRT(f, 4, False)
Expected:
    [
    [1 0]  [-1  0]  [0 1]  [ 0 -1]  [-1  1]  [ 1  1]  [ 1 -1]  [-1 -1]
    [0 1], [ 0  1], [1 0], [ 1  0], [ 1  1], [ 1 -1], [ 1  1], [ 1 -1]
    ]
Got:
    [
    [1 0]  [-1  0]  [0 1]  [ 0 -1]  [-1  1]  [ 1  1]  [-1 -1]  [ 1 -1]
    [0 1], [ 0  1], [1 0], [ 1  0], [ 1  1], [ 1 -1], [ 1 -1], [ 1  1]
    ]
**********************************************************************
1 item had failures:
   2 of   9 in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphism_group_QQ_CRT

comment:3 Changed 11 months ago by jhpalmieri

But if you remove dynamics from the list of good directories, positive review.

comment:4 Changed 11 months ago by chapoton

maybe we can rather sort these doctests ?

comment:5 Changed 11 months ago by git

  • Commit changed from 242226f737a195c96f7c2d755c1372a1fb3fef5c to 697a1b9834fac269fb7317ded9b8984238e67990

Branch pushed to git repo; I updated commit sha1. New commits:

697a1b9sorting some flaky doctests in dynamics

comment:6 Changed 11 months ago by chapoton

ok, I have added sorted and changed the doctests. Now the bots will not manage to check this ticket, because the python3-list is (stupidly) not in s "safe" location..

Version 0, edited 11 months ago by chapoton (next)

comment:7 Changed 11 months ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Okay with me.

comment:8 Changed 11 months ago by vbraun

  • Branch changed from u/chapoton/27867 to 697a1b9834fac269fb7317ded9b8984238e67990
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.