Opened 2 years ago

Closed 2 years ago

#27857 closed enhancement (fixed)

some pep cleanup in graph, posets, Hopf algebras

Reported by: chapoton Owned by:
Priority: trivial Milestone: sage-8.8
Component: combinatorics Keywords:
Cc: tscrim, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 9c524c8 (Commits, GitHub, GitLab) Commit: 9c524c8ed53de52cf0f1717f62a83da0e8e6a893
Dependencies: Stopgaps:

Status badges

Description


Change History (6)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/27857
  • Commit set to a72236009534d5985d2de58c211f9db4cfd19491
  • Status changed from new to needs_review

New commits:

a722360various pep cleanups in graphs, posets, Hopf algebras

comment:2 Changed 2 years ago by chapoton

  • Cc tscrim jmantysalo added

green bot, please review (trivial ticket)

comment:3 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

I think it is better to have the comment on the other side.

-        elem = [[top]] # Make a list of lists of elements in the interval divided by rank.
-                       # List will be flattened at the end
+        elem = [[top]]
+        # Make a list of lists of elements in the interval divided by rank.
+        # List will be flattened at the end

Once done, you can set a positive review on my behalf.

comment:4 Changed 2 years ago by git

  • Commit changed from a72236009534d5985d2de58c211f9db4cfd19491 to 9c524c8ed53de52cf0f1717f62a83da0e8e6a893

Branch pushed to git repo; I updated commit sha1. New commits:

dea10cdMerge branch 'u/chapoton/27857' in 8.8.b6
9c524c8trac 27857 fix some details

comment:5 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

thx, done. Setting to positive

comment:6 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/27857 to 9c524c8ed53de52cf0f1717f62a83da0e8e6a893
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.