Opened 3 years ago
Closed 3 years ago
#27854 closed defect (fixed)
Port cluster_algebra_seed to py3
Reported by:  etn40ff  Owned by:  

Priority:  major  Milestone:  sage8.8 
Component:  combinatorics  Keywords:  
Cc:  chapoton  Merged in:  
Authors:  Salvatore Stella  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  5c7a46f (Commits, GitHub, GitLab)  Commit:  5c7a46fa97d056b6eeee61e1ff2648cff1171cc4 
Dependencies:  Stopgaps: 
Description
This ticket fixes the remaining doctest failures in cluster_algebra_seed
; these were all due to the usual issue with sorting.
There is still a failure, namely
File "src/sage/combinat/cluster_algebra_quiver/quiver.py", line 1079, in sage.combinat.cluster_algebra_quiver.quiver.ClusterQuiver.frozen_vertices Failed example: Q.frozen_vertices() Expected: ['b', 'd'] Got: ['d', 'b']
that seems to happen only 50% of the times. Does anyone here know what could this depend on?
Change History (6)
comment:1 Changed 3 years ago by
 Status changed from new to needs_review
comment:2 Changed 3 years ago by
comment:3 Changed 3 years ago by
 Commit changed from f3525bea6d50c71355a1f57b8749159c7148b490 to 5c7a46fa97d056b6eeee61e1ff2648cff1171cc4
Branch pushed to git repo; I updated commit sha1. New commits:
5c7a46f  sorted

comment:5 Changed 3 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
no idea. Maybe a dictionary somewhere.
comment:6 Changed 3 years ago by
 Branch changed from u/etn40ff/cluster_seed_py3 to 5c7a46fa97d056b6eeee61e1ff2648cff1171cc4
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
ok, thx. Can you please add a sorted in front of the random doctest, and it will be good to go.