Opened 3 years ago

Closed 3 years ago

#27827 closed enhancement (fixed)

spkg-configure.m4 for pkgconf

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.9
Component: build: configure Keywords:
Cc: embray, fbissey, isuruf, arojas Merged in:
Authors: Dima Pasechnik Reviewers: Isuru Fernando
Report Upstream: N/A Work issues:
Branch: ed84fa2 (Commits, GitHub, GitLab) Commit: ed84fa259632a6dd5319e25ae69df2b6ac08b652
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

pkgconf is an implementation of widely used pkg-config. In fact, pkg-config can be configured to look at certain directories, so we can use the one on the system.

This is what the branch does - it check for pkg-config presense, and if it is there is sets up/updates the env.var. PKG_CONFIG_PATH in src/bin/sage-env-config. As pkg-config looks in dirs in PKG_CONFIG_PATH first, anything that Sage installs there overrides the system ones.

Change History (13)

comment:1 Changed 3 years ago by embray

  • Milestone sage-8.8 deleted

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

comment:2 Changed 3 years ago by dimpase

  • Milestone set to sage-8.9

the plan is to install PKG_CONFIG_PATH=SAGE_LOCAL/lib/pkgconfig into src/bin/sage-env-config in case the system has pkg-config installed.

comment:3 Changed 3 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/packages/pkgconf
  • Commit set to f77b4c1ee2217c14d1fc0e9da72845de8234ddd3

New commits:

f77b4c1spkg-configure.m4 for pkgconf

comment:4 Changed 3 years ago by git

  • Commit changed from f77b4c1ee2217c14d1fc0e9da72845de8234ddd3 to 836f5ba968c1ae0ca0a580e476f79c9957e8490f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

836f5baspkg-configure.m4 for pkgconf

comment:5 Changed 3 years ago by dimpase

  • Cc embray fbissey isuruf added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:6 Changed 3 years ago by dimpase

  • Cc arojas added

comment:7 Changed 3 years ago by isuruf

  • Reviewers set to Isuru Fernando
  • Status changed from needs_review to positive_review

Works for me

comment:8 Changed 3 years ago by git

  • Commit changed from 836f5ba968c1ae0ca0a580e476f79c9957e8490f to 3b95f60d00ef162d5154bf35e85e46da24c98e74
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

3b95f60spkg-configure.m4 for pkgconf

comment:9 Changed 3 years ago by dimpase

  • Status changed from needs_review to positive_review

rebased over 8.9.beta3

comment:10 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:11 Changed 3 years ago by git

  • Commit changed from 3b95f60d00ef162d5154bf35e85e46da24c98e74 to ed84fa259632a6dd5319e25ae69df2b6ac08b652

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ed84fa2spkg-configure.m4 for pkgconf

comment:12 Changed 3 years ago by dimpase

  • Status changed from needs_work to positive_review

rebased over Sage 8.9.beta4

comment:13 Changed 3 years ago by vbraun

  • Branch changed from u/dimpase/packages/pkgconf to ed84fa259632a6dd5319e25ae69df2b6ac08b652
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.