Opened 4 years ago

Closed 4 years ago

#27822 closed task (fixed)

Update configure with checks for mpfr, mpc, and ntl

Reported by: Erik Bray Owned by:
Priority: major Milestone: sage-8.8
Component: build: configure Keywords: spkg-configure mpfr mpc ntl
Cc: Dima Pasechnik Merged in:
Authors: Erik Bray Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: cb88c8d (Commits, GitHub, GitLab) Commit: cb88c8d07a0c922e2570c9fedba4179da03349bf
Dependencies: Stopgaps:

Status badges

Description (last modified by Dima Pasechnik)

This ticket bundles together #27258, #27259, and #27265 in such a way that the configure tarball is updated to contain the configure changes from each of those tickets.

Once all three have been merged (or at the same time) this ticket can also be merged to bump the configure version.

Updated configure: http://users.ox.ac.uk/~coml0531/sage/configure-321.tar.gz

Attachments (1)

configure-319.tar.gz (109.9 KB) - added by Erik Bray 4 years ago.
Updated configure

Download all attachments as: .zip

Change History (24)

comment:1 Changed 4 years ago by Erik Bray

Authors: Erik Bray
Branch: u/embray/build/ticket-27822
Commit: de42045e1d7294617640a0ea1cb6f6e2627cff91

New commits:

d5e5e3dspkg-configure for mpfr, adjustments for its dependees
0329fd9Add one missing SAGE_CONFIGURE_MPFR, for building gcc
d15ead5Trac #27259: spkg-configure for mpc, adjustments for its dependents
974c483Trac #27265: Add spkg-configure.m4 for ntl
de42045Trac #27822: Update configure tarball to include configure time checks for mpfr, mpc, and ntl

comment:2 Changed 4 years ago by Erik Bray

Description: modified (diff)

comment:3 Changed 4 years ago by Erik Bray

It occurs to me actually that we probably can't merge any of #27258, #27259, #27265 without this ticket: Due to the changes in src/bin/sage-env-config.in Sage won't build properly anymore without an updated configure script that makes the necessary replacements in that file.

Therefore, I believe the other tickets should just be closed, and only this one merged.

comment:4 Changed 4 years ago by Erik Bray

Status: newneeds_review

comment:6 Changed 4 years ago by git

Commit: de42045e1d7294617640a0ea1cb6f6e2627cff91e7683802079f4ef820e2f79ebf44ef6df60e6783

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

96a7d77correct use of AC_LINK_IFELSE
4b3caa7flint needs --with-ntl= always
e768380Trac #27822: Update configure tarball to include configure time checks for mpfr, mpc, and ntl

Changed 4 years ago by Erik Bray

Attachment: configure-319.tar.gz added

Updated configure

comment:7 Changed 4 years ago by Erik Bray

Rebased again on #27265 and updated the configure tarball. Please double-check I didn't make any mistakes.

comment:8 Changed 4 years ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

this appears to be good.

comment:9 Changed 4 years ago by Dima Pasechnik

Status: positive_reviewneeds_review

here one has to cherry pick the last commit from public/packages/ntlconf - the one that adds missing quotes, namely

892143a2d89591044dc20a3c87ecccaffdd46dd7

and redo the configure tarball dance...

Last edited 4 years ago by Dima Pasechnik (previous) (diff)

comment:10 Changed 4 years ago by Volker Braun

configure-319 is the current confball, you always need to increment it

comment:11 Changed 4 years ago by Volker Braun

Please do a full rebuild BEFORE you set any of #27258, #27259, #27265, #27822 back to positive review.

comment:12 Changed 4 years ago by Dima Pasechnik

I've rebuilt these tickets dozens of times, it's never clear w.r.t. the release process whether they will be picked in 10 minutes after they are set to positive review, or sit idle for weeks, bit-rotting.

comment:13 Changed 4 years ago by Dima Pasechnik

Branch: u/embray/build/ticket-27822public/build/ticket-27822
Commit: e7683802079f4ef820e2f79ebf44ef6df60e67833841611450b4aa6c3fdf9ee8f83c474dc143505d
Description: modified (diff)

New commits:

879dfa5add missing quotes
3841611new configure tarball

comment:14 Changed 4 years ago by Dima Pasechnik

Dependencies: #27258, #27259, #27265

comment:15 Changed 4 years ago by Dima Pasechnik

Status: needs_reviewpositive_review

comment:16 Changed 4 years ago by Volker Braun

320 is used for 8.8.beta6, can you resolve the merge conflict and make a v321

comment:17 Changed 4 years ago by Volker Braun

Status: positive_reviewneeds_work

comment:18 Changed 4 years ago by Dima Pasechnik

sure, as soon as there is a public 8.8.beta6 branch available (nether trac nor github have it)

comment:19 Changed 4 years ago by git

Commit: 3841611450b4aa6c3fdf9ee8f83c474dc143505dcb88c8d07a0c922e2570c9fedba4179da03349bf

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d64963aspkg-configure for mpfr, adjustments for its dependees
5e28c6eAdd one missing SAGE_CONFIGURE_MPFR, for building gcc
32b79afTrac #27259: spkg-configure for mpc, adjustments for its dependents
b986753Trac #27265: Add spkg-configure.m4 for ntl
d7ec6abcorrect use of AC_LINK_IFELSE
7871a34flint needs --with-ntl= always
b4c6a96add missing quotes
cb88c8dnew config tarball

comment:20 Changed 4 years ago by Dima Pasechnik

Description: modified (diff)

rebased over 8.8.beta6, new config tarball (version 321)

comment:21 Changed 4 years ago by Dima Pasechnik

Status: needs_workneeds_review

comment:22 Changed 4 years ago by Dima Pasechnik

Status: needs_reviewpositive_review

comment:23 Changed 4 years ago by Volker Braun

Branch: public/build/ticket-27822cb88c8d07a0c922e2570c9fedba4179da03349bf
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.