Opened 3 years ago
Closed 3 years ago
#27820 closed defect (wontfix)
revert #27642 in Sage 8.8.beta5
Reported by: | dimpase | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | sage-duplicate/invalid/wontfix |
Component: | build: configure | Keywords: | |
Cc: | embray, vbraun | Merged in: | |
Authors: | Reviewers: | Dima Pasechnik | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
this happened too early. :-(
Change History (8)
comment:1 Changed 3 years ago by
comment:2 Changed 3 years ago by
Well, as soon as a ticket is positively reviewed, and it was in this state for a couple of days, Volker may grab it and merge it....
comment:3 Changed 3 years ago by
- Status changed from new to needs_info
Is there something that remains to be done, or has it been fixed in the meantime?
comment:4 Changed 3 years ago by
I don't understand the state of #27642. It is maked as fixed, but the branch is still there.
comment:5 Changed 3 years ago by
There seem to be no code changes on the attached branch at #27642, i.e. whatever is there has been merged by now. It could be reverted, but I have no idea why.
comment:6 Changed 3 years ago by
- Milestone changed from sage-8.8 to sage-duplicate/invalid/wontfix
- Status changed from needs_info to positive_review
The branch of #27642 has been merged in some (probably, forced) way. So all of it it in, no worries.
comment:7 Changed 3 years ago by
- Reviewers set to Dima Pasechnik
comment:8 Changed 3 years ago by
- Resolution set to wontfix
- Status changed from positive_review to closed
I have a better idea: Let's just leave it for now and I can finish it in a follow-up. As far as I'm concerned it fixes the overall issue; it just needed some additional work.
I'm still confused as to how/why it was merged at all.