Opened 3 years ago

Closed 3 years ago

#27818 closed enhancement (fixed)

Meet-subsemilattice for lattices

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-8.9
Component: combinatorics Keywords:
Cc: tscrim, chapoton Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 558aa41 (Commits, GitHub, GitLab) Commit: 558aa41dd7e640755cb7bd3144e0c46a7defdc28
Dependencies: Stopgaps:

Status badges

Description

This patch contains a function to compute subsemilattice of semilattice.

Change History (8)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/meet-subsemilattice

comment:2 Changed 3 years ago by jmantysalo

  • Cc tscrim chapoton added
  • Commit set to ab1db665e53a959fee2d6376fcfe343403a63216
  • Status changed from new to needs_info

What should be the name of this (and the dual function for join-semilattices)?


New commits:

ab1db66Add meet_subsemilattice().

comment:3 Changed 3 years ago by embray

  • Milestone changed from sage-8.8 to sage-8.9

Tickets still needing working or clarification should be moved to the next release milestone at the soonest (please feel free to revert if you think the ticket is close to being resolved).

comment:4 follow-up: Changed 3 years ago by tscrim

I think submeetsemilattice would be a better name since it is a subobject that is a meetsemilattice. The current name could be interpreted as the meet in a subsemilattice.

comment:5 Changed 3 years ago by git

  • Commit changed from ab1db665e53a959fee2d6376fcfe343403a63216 to 558aa41dd7e640755cb7bd3144e0c46a7defdc28

Branch pushed to git repo; I updated commit sha1. New commits:

4cddf19Change name.
558aa41Merge branch 'develop' into t/27818/meet-subsemilattice

comment:6 in reply to: ↑ 4 Changed 3 years ago by jmantysalo

  • Status changed from needs_info to needs_review

Replying to tscrim:

I think submeetsemilattice would be a better name - -

OK, done that.

comment:7 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks. LGTM.

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/meet-subsemilattice to 558aa41dd7e640755cb7bd3144e0c46a7defdc28
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.