Opened 5 months ago

Closed 4 months ago

#27817 closed defect (fixed)

remove SAGE_INSTALL_GCC variable

Reported by: dimpase Owned by: dimpase
Priority: major Milestone: sage-8.8
Component: documentation Keywords:
Cc: fbissey, embray, jdemeyer, mkoeppe, nthiery Merged in:
Authors: Dima Pasechnik Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: a9c8ddd (Commits) Commit: a9c8dddf6a002a2b0b9c4e6c3e213918b80883da
Dependencies: Stopgaps:

Description (last modified by dimpase)

I think with the latest —with-system-* options, it can and should be removed as superseded.

The branch here updated docs to make SAGE_INSTALL_GCC obsolete and removed it everywhere, except one place. Alternative means to use system compilers are explained.

The actual removal from the code will be done in a follow-up ticket.

Change History (11)

comment:1 Changed 5 months ago by embray

I think so too, though we might need better docs on how to run configure with specific flags when building from source.

This section of the installation docs mentions it, but it assumes you're building from a released source tarball, which already contains the configure script.

Whereas when building from a git checkout, which more and more people are likely to do these days, it's necessary to at least run make configure first (which, while slightly unusual, is I think justifiable).

comment:2 Changed 5 months ago by dimpase

I agree that this should include the needed changes. These docs need cleaning badly, see e.g.

Building all of Sage with Clang is currently not supported, see trac ticket #12426

which is manifestly not true, etc.

comment:3 Changed 5 months ago by dimpase

  • Owner changed from (none) to dimpase

OK, let me try to fix this.

comment:4 Changed 5 months ago by dimpase

  • Branch set to public/documentation/remove_sage_install_gcc
  • Commit set to 4b5129c8df93fa2fc277cb4e1ed94622ea3ec176

and this is only README.md fixes... (naturally, I could not stop until I made the whole text to reflect realty much better than it was)

Last edited 5 months ago by dimpase (previous) (diff)

comment:5 Changed 5 months ago by dimpase

SAGE_INSTALL_GCC is used for two more or less orthogonal purposes: get input from the user, and for updating the toolchain (that's where it set to/tested for exists value).

Refactoring this is going to be fun...

comment:6 Changed 5 months ago by git

  • Commit changed from 4b5129c8df93fa2fc277cb4e1ed94622ea3ec176 to a9c8dddf6a002a2b0b9c4e6c3e213918b80883da

Branch pushed to git repo; I updated commit sha1. New commits:

a9c8dddmarked SAGE_INSTALL_GCC obsolete, updated installation manual

comment:7 Changed 5 months ago by dimpase

  • Authors set to Dima Pasechnik
  • Cc jdemeyer added
  • Component changed from build: configure to documentation
  • Description modified (diff)
  • Status changed from new to needs_review

Don't know whether we should document how to force building of GCC. (using --without-system-gcc, that is).

It is still far from ideal, but already a step forward from the hugely obsolete installation docs.

comment:8 Changed 5 months ago by dimpase

  • Cc mkoeppe added

comment:9 Changed 5 months ago by dimpase

  • Cc nthiery added

these are really badly overdue documentation changes. let us get them in soon.

comment:10 Changed 5 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

Looks good to me. A major improvement.

comment:11 Changed 4 months ago by vbraun

  • Branch changed from public/documentation/remove_sage_install_gcc to a9c8dddf6a002a2b0b9c4e6c3e213918b80883da
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.