Opened 3 years ago

Closed 3 years ago

#27813 closed defect (fixed)

Implement _im_gens_ for LaurentPolynomial_mpair

Reported by: soehms Owned by:
Priority: major Milestone: sage-9.0
Component: algebra Keywords:
Cc: tscrim Merged in:
Authors: Sebastian Oehms Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ecbca8c (Commits, GitHub, GitLab) Commit: ecbca8c222898f06cd87693ef17d0425a5f46163
Dependencies: Stopgaps:

Status badges

Description

Currently the application of ring homomorphisms from multivariate Laurent polynomial rings fails: 

sage: L.<x,y> = LaurentPolynomialRing(ZZ)
sage: M.<u,v> = LaurentPolynomialRing(ZZ)
sage: phi = L.hom([u,v])
sage: phi(x)
Traceback (most recent call last):
...
NotImplementedError:

The reason is that method _im_gens_ has not been implemented in that special case. This will be included by the ticket!

Change History (13)

comment:1 Changed 3 years ago by soehms

  • Branch set to u/soehms/laurent_mpair_im_gens_27813

comment:2 Changed 3 years ago by soehms

  • Commit set to 170f4a6ccd6f8b18dff78cb0febf986e7eba21f0
  • Status changed from new to needs_review

New commits:

​170f4a627813: initial version

comment:3 Changed 3 years ago by embray

  • Milestone changed from sage-8.8 to sage-8.9

Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).

comment:4 Changed 3 years ago by git

  • Commit changed from 170f4a6ccd6f8b18dff78cb0febf986e7eba21f0 to 71e2dc9fb36ef1327ed8ca53b0e7a64e11ae62e5

Branch pushed to git repo; I updated commit sha1. New commits:

​71e2dc9Merge branch 'u/soehms/laurent_mpair_im_gens_27813' of git://trac.sagemath.org/sage into laurent_poly_mpair_im_gens_27813

comment:5 Changed 3 years ago by git

  • Commit changed from 71e2dc9fb36ef1327ed8ca53b0e7a64e11ae62e5 to 136c7d1c7341dd4793fb244e2b8234b701b93b04

Branch pushed to git repo; I updated commit sha1. New commits:

​136c7d127813: fix incompatibility with 9.0.beta1 (#26105)

comment:6 Changed 3 years ago by soehms

  • Cc tscrim added
  • Milestone changed from sage-8.9 to sage-9.0

comment:7 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 3 years ago by git

  • Commit changed from 136c7d1c7341dd4793fb244e2b8234b701b93b04 to 6cdcb4a6cd9dd6696c08e8dd1f99edeb2e8f5992
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​6cdcb4a27813: correction of former commit

comment:9 Changed 3 years ago by soehms

Thanks and sorry, Travis! My fix with respect to #26105 was a little bit to quick and stupid. I think it is due to the usage of generic keywords, that the doctests didn't detect this. So they dazzled us both! Can you please have a look at it again?

comment:10 Changed 3 years ago by tscrim

Minor docfix: 

-        TESTS::
+        TESTS:
 
-        check compatibility with  :trac:`26105`:
+        check compatibility with  :trac:`26105`::

once done, you can set a positive review on my behalf.

comment:11 Changed 3 years ago by git

  • Commit changed from 6cdcb4a6cd9dd6696c08e8dd1f99edeb2e8f5992 to ecbca8c222898f06cd87693ef17d0425a5f46163

Branch pushed to git repo; I updated commit sha1. New commits:

​ecbca8c27813: fix doctest

comment:12 Changed 3 years ago by soehms

  • Status changed from needs_review to positive_review

Thanks again!

comment:13 Changed 3 years ago by vbraun

  • Branch changed from u/soehms/laurent_mpair_im_gens_27813 to ecbca8c222898f06cd87693ef17d0425a5f46163
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.