Opened 2 years ago
Closed 2 years ago
#27812 closed enhancement (fixed)
py3: fix comparison of constants
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.8 
Component:  python3  Keywords:  
Cc:  tscrim, rws  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  b30879a (Commits, GitHub, GitLab)  Commit:  b30879a11fa2025225f111ed10f63550250260e4 
Dependencies:  Stopgaps: 
Description
of pi < pi in particular
Change History (7)
comment:1 Changed 2 years ago by
 Branch set to u/chapoton/27812
 Commit set to a87b6448b56495f36d81602d97953087055f8e0d
 Status changed from new to needs_review
comment:3 Changed 2 years ago by
Is there a reason why equality
is a separate variable and not just part of the if
statement?
comment:4 Changed 2 years ago by
 Commit changed from a87b6448b56495f36d81602d97953087055f8e0d to b30879a11fa2025225f111ed10f63550250260e4
Branch pushed to git repo; I updated commit sha1. New commits:
b30879a  detail

comment:5 Changed 2 years ago by
indeed, fixed
comment:6 Changed 2 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
Thank you. LGTM.
comment:7 Changed 2 years ago by
 Branch changed from u/chapoton/27812 to b30879a11fa2025225f111ed10f63550250260e4
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
py3: improve comparison of pi with pi (for constants in general)