Opened 3 years ago
Closed 3 years ago
#27803 closed defect (fixed)
Fix polymake 3.4's lrslib detection, add dependency on ppl
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.8 |
Component: | packages: experimental | Keywords: | |
Cc: | dimpase, paffenholz@…, lorenz@…, vbraun | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | public/27803-polymake-lrslib-detection (Commits, GitHub, GitLab) | Commit: | 59161415289ce3256a260a8d798df7d95071658a |
Dependencies: | #24905 | Stopgaps: |
Description
polymake 3.4 has an updated lrslib detection code that fails to recognize the installed lrslib from Sage on macOS.
Change History (11)
comment:1 Changed 3 years ago by
- Branch set to public/27803-polymake-lrslib-detection
comment:2 follow-up: ↓ 3 Changed 3 years ago by
- Commit set to 59161415289ce3256a260a8d798df7d95071658a
comment:3 in reply to: ↑ 2 Changed 3 years ago by
Replying to mkoeppe:
Dima - of course, adding
--with-lrs="$SAGE_LOCAL"
to polymake's configure conflicts with your efforts withspkg-configure.m4
. What should I do?
No worries, lrs
has not been spkg-configurified yet, see #27330 (your help in reviewing there is most welcome, by the way, e.g. all these readline and curses packages...). We should do lrs
too, I just opened #27804 for this. So we will need to change that hardcoded value of its prefix to whatever configure finds. Already did this for GMP etc, so no big problem
I gather.
comment:4 Changed 3 years ago by
- Cc paffenholz@… added
comment:5 Changed 3 years ago by
ready for review?
comment:6 Changed 3 years ago by
- Status changed from new to needs_review
comment:7 Changed 3 years ago by
- Cc lorenz@… added
The relevant output (without this patch) from polymake's configure in build/bundled.log
:
---- lrs ---- Could not compile a test program checking for lrs library. The most probable reasons are that the library is installed at a non-standard location, is not configured to build a shared module, or missing at all. The complete error log follows: ld: library not found for -llrs clang: error: linker command failed with exit code 1 (use -v to see invocation) Please install the library and specify its location using --with-lrs option, if needed. Please remember to enable shared modules when configuring the lrs library!
As Benjamin pointed out, the error message does not match the one expected by bundled/lrs/support/configure.pl
script, which tries to be too helpful.
comment:8 Changed 3 years ago by
- Summary changed from Fix polymake 3.4's lrslib detection to Fix polymake 3.4's lrslib detection, add dependency on ppl
comment:9 Changed 3 years ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_review to positive_review
tests fine.
comment:10 Changed 3 years ago by
- Cc vbraun added
comment:11 Changed 3 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
This branch has been merged already as part of #22704.
Dima - of course, adding
--with-lrs="$SAGE_LOCAL"
to polymake's configure conflicts with your efforts withspkg-configure.m4
. What should I do?Last 10 new commits:
Added two missing optional tags
Change format of a 'not tested' doc test annotation
update docs, as discussed on #24905
Mention libterm-readkey-perl
Mention libterm-readline-gnu-perl
polymake: Mention MOngoDB for polydb
polymake: Update info on macOS
polymake: update MongoDB information for linux distros
polymake: add to fedora instructions
Fix polymake lrslib detection