Opened 2 years ago
Closed 2 years ago
#27799 closed enhancement (fixed)
AsymptoticRing.coefficients_of_generating_function: specify error term
Reported by:  dkrenn  Owned by:  

Priority:  major  Milestone:  sage8.8 
Component:  asymptotic expansions  Keywords:  
Cc:  behackl  Merged in:  
Authors:  Daniel Krenn  Reviewers:  Benjamin Hackl 
Report Upstream:  N/A  Work issues:  
Branch:  c605e31 (Commits, GitHub, GitLab)  Commit:  c605e31b98421d583c9ec1c5d06308b7b1e66a0e 
Dependencies:  Stopgaps: 
Description
sage: def f(z): ....: return z/(1z) sage: B.coefficients_of_generating_function(f, (1,), precision=3)
Reports O(0)
, but one cannot get around this. By specifying an error term, this would work.
Change History (6)
comment:1 Changed 2 years ago by
 Branch set to u/dkrenn/coeffgferrorterm
comment:2 Changed 2 years ago by
 Cc behackl added
 Commit set to d548b1086aaabef8c7d4187a86e7c4cdaf3f7ba0
 Status changed from new to needs_review
comment:3 Changed 2 years ago by
This needed some changes (and some cleanup) of NotImplementedOZero
comment:4 Changed 2 years ago by
 Commit changed from d548b1086aaabef8c7d4187a86e7c4cdaf3f7ba0 to c605e31b98421d583c9ec1c5d06308b7b1e66a0e
Branch pushed to git repo; I updated commit sha1. New commits:
c605e31  cleanup import (pyflakes warning)

comment:5 Changed 2 years ago by
 Reviewers set to Benjamin Hackl
 Status changed from needs_review to positive_review
If I see this correctly, the currently remaining pyflakes warnings are also taken care of due to #27759, so the patchbot is happy.
The changes in the code look good to me. (And I've run into the same issue before, so thanks for fixing!)
comment:6 Changed 2 years ago by
 Branch changed from u/dkrenn/coeffgferrorterm to c605e31b98421d583c9ec1c5d06308b7b1e66a0e
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
rewrite/cleanup NotImplementedOZero
fix code/doctests to follow changes in NotImplementedOZero
error_term for coefficients_of_generating_function
Merge tag '8.8.beta4' into u/dkrenn/coeffgferrorterm