Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#27795 closed enhancement (fixed)

spkg-configure.m4 for perl_term_readline_gnu

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.8
Component: build: configure Keywords:
Cc: mkoeppe, embray, jipilab Merged in:
Authors: Dima Pasechnik Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: ed89d81 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by dimpase)

this is a slightly non-standard perl module we happen to have an spkg for, used in polymake interface.

On Debian this module is in libterm-readline-gnu-perl.

Attachments (1)

polymake-3.4.log (222.4 KB) - added by jipilab 10 months ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 10 months ago by dimpase

  • Status changed from new to needs_review

comment:2 Changed 10 months ago by mkoeppe

Seems to work on macOS, where Term::Readline is non-GNU.

comment:3 Changed 10 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe

comment:4 Changed 10 months ago by mkoeppe

  • Cc jipilab added

comment:5 follow-up: Changed 10 months ago by dimpase

for some reason I not only had to run ./bootstrap, but also aclocal --- otherwise the new macro in m4/ just didn’t want to get expanded.

Last edited 10 months ago by dimpase (previous) (diff)

comment:6 in reply to: ↑ 5 Changed 10 months ago by mkoeppe

Replying to dimpase:

for some reason I not only had to run ./bootstrap, but also aclocal --- otherwise the new macro in m4/ just didn’t want to get expanded.

Worked for me without even calling bootstrap explicitly.

comment:7 Changed 10 months ago by dimpase

Without ./bootstrap the answer would be always "no", regardless of good Term::ReadLine::Gnu being available. Cause the m4 file in question gets collected by ./bootstrap into m4/sage_spkg_configures.m4 to be used in ./configure.

Without running ./bootstrap it won't make any difference.

comment:8 Changed 10 months ago by mkoeppe

I agree, but bootstrap, of course, gets run automatically by make install. At least in my test I verified that it was run and that your configuration script detected a non-GNU Term::Readline.

I would be inclined to set it to positive review, but it could perhaps use another round of testing on a Linux system.

comment:9 Changed 10 months ago by dimpase

  • Description modified (diff)

I just tried on stable Debian, and without debian package libterm-readline-gnu-perl the spkg is marked as to be installed, whereas if I install libterm-readline-gnu-perl then it is marked as not to be installed.

comment:10 Changed 10 months ago by mkoeppe

  • Status changed from needs_review to positive_review

comment:11 follow-up: Changed 10 months ago by embray

Yikes now we have to go searching for perl modules too? Nevertheless, thank you for taking care of it.

comment:12 in reply to: ↑ 11 Changed 10 months ago by dimpase

Replying to embray:

Yikes now we have to go searching for perl modules too? Nevertheless, thank you for taking care of it.

Yes we can! Onward with experimental interfaces to Haskell, Julia, Coq! :-)

comment:13 Changed 10 months ago by vbraun

  • Branch changed from u/dimpase/packages/perltermreadline-config to ed89d81203a7c8783bdc6302da8bd57d57143c34
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:14 follow-up: Changed 10 months ago by jipilab

  • Commit ed89d81203a7c8783bdc6302da8bd57d57143c34 deleted

Hi, I know that this ticket is closed, by I thought it makes sense to mention this here anyways:

I just installed polymake through sage on my office computer and it was not working unless the experimental package perl_term_readline_gnu was installed.

Now, this is without the present ticket, but perhaps my question is still relevant: shouldn't perl_term_readline_gnu be a dependancy of polymake?

comment:15 in reply to: ↑ 14 Changed 10 months ago by jipilab

Replying to jipilab:

Hi, I know that this ticket is closed, by I thought it makes sense to mention this here anyways:

I just installed polymake through sage on my office computer and it was not working unless the experimental package perl_term_readline_gnu was installed.

Now, this is without the present ticket, but perhaps my question is still relevant: shouldn't perl_term_readline_gnu be a dependancy of polymake?

Now, I checked... It is a dependency but I have no idea why it did not install it at first run (it is true that the installation crashed due to the lack of json, that I then fixed) and then installing polymake again perhaps thought that perl_term_readline_gnu was succesfully installed. That could explain it.

--> In any case, having polymake move slowly to a stable optional package is definitely a huge positive progress. Thanks for this work!

comment:16 follow-up: Changed 10 months ago by dimpase

hmm, installation of what package did crash due to no json?

comment:17 in reply to: ↑ 16 Changed 10 months ago by jipilab

Replying to dimpase:

hmm, installation of what package did crash due to no json?

polymake. But that was my mistake, I did not install the perl-json package prior to running ./sage -i polymake. Then installed json, then ran ./sage -i polymake with success, but apparently skipped the dependency.

Changed 10 months ago by jipilab

comment:18 Changed 10 months ago by dimpase

I just cc'd you on the relevant ticket.

Note: See TracTickets for help on using tickets.