Opened 3 years ago

Closed 3 years ago

#27794 closed defect (fixed)

py3: doctests in sets

Reported by: jhpalmieri Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: bca7237 (Commits, GitHub, GitLab) Commit: bca723785da36e2c1e407ee337ff82ff67ae8bdd
Dependencies: Stopgaps:

Status badges

Description

Fix the remaining py3 doctest failures in sets.

Change History (4)

comment:1 Changed 3 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/sets-py3

comment:2 Changed 3 years ago by jhpalmieri

  • Commit set to bca723785da36e2c1e407ee337ff82ff67ae8bdd
  • Status changed from new to needs_review

One fix is just different formatting for a pickling error in py2 vs. py3. The other comes from a warning being printed in py3 but not py2. The warning is printed at the command line in both versions, but in doctesting only in py3.

New commits:

​bca7237trac 27794: py3 doctests in sets

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/jhpalmieri/sets-py3 to bca723785da36e2c1e407ee337ff82ff67ae8bdd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.