Opened 14 years ago

Closed 12 years ago

#2779 closed defect (fixed)

Error message for notebook server already running is misleading

Reported by: justin Owned by: boothby
Priority: minor Milestone: sage-4.3.1
Component: notebook Keywords:
Cc: Merged in: sagenb-0.6
Authors: Tim Dumol Reviewers: Willem Palenstijn
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

If I have a notebook server already running, and I start a new one, I get something like this:

----------------------------------------------------------------------
| SAGE Version 2.11, Release Date: 2008-03-30                        |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------

Please wait while the SAGE Notebook server starts...
...
The notebook files are stored in: /Users/justin/.sage//sage_notebook
Port 8000 is already in use.
Trying next port...
****************************************************
*                                                  *
* Open your web browser to https://localhost:8001  *
*                                                  *
****************************************************
There is an admin account.  If you do not remember the password,
quit the notebook and type notebook(reset=True).
Another twistd server is running, PID 19662

This could either be a previously started instance of your application or a
different application entirely. To start a new one, either run it in some other
directory, or use the --pidfile and --logfile parameters to avoid clashes.

It's not clear how to use the second suggestion (using the additional parameters), and I sure couldn't get it to work.

Using an alternate directory does work, but that somehow didn't come through in this error message.

Attachments (2)

trac_2779-sagenb-error-message.patch (1.7 KB) - added by timdumol 12 years ago.
Outputs a clearer error message (see comment)
2779_2_banner.patch (1.5 KB) - added by wjp 12 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 14 years ago by mabshoff

  • Milestone set to sage-3.0

comment:2 Changed 14 years ago by was

Could you suggest a specific better error message? Oh, and post a patch :-)

comment:3 Changed 12 years ago by timdumol

  • Authors set to Tim Dumol
  • Report Upstream set to N/A
  • Status changed from new to needs_review

This new patch should do it. It outputs the following message instead:

Another Sage Notebook server is running, PID 13463.

Please either stop the old server or run the new server in a different directory.

Changed 12 years ago by timdumol

Outputs a clearer error message (see comment)

Changed 12 years ago by wjp

comment:4 Changed 12 years ago by wjp

Positive review for Tim's patch. It works great for me.

I've added a second minor patch (to be applied after trac_2779-sagenb-error-message.patch) that moves displaying the "Please open your browser" banner to below the check Tim added.

comment:5 Changed 12 years ago by timdumol

  • Reviewers set to Willem Palenstijn
  • Status changed from needs_review to positive_review

Positive review on the reviewer patch. I'll mark this as positive review now.

comment:6 Changed 12 years ago by timdumol

  • Merged in set to sagenb-0.6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.