Opened 2 years ago

Closed 2 years ago

#27782 closed defect (fixed)

1 pynormaliz doctest failing in src/sage/geometry/polyhedron/backend_normaliz.py

Reported by: slabbe Owned by:
Priority: major Milestone: sage-8.8
Component: geometry Keywords:
Cc: jipilab Merged in:
Authors: Matthias Koeppe Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: 9b3a5ba (Commits, GitHub, GitLab) Commit: 9b3a5baab1c7c4144ce9d420d36278f3cb53e7d1
Dependencies: Stopgaps:

Status badges

Description

With SageMath version 8.8.beta4, Release Date: 2019-05-04,

sage -t --long src/sage/geometry/polyhedron/backend_normaliz.py

gives

Using --optional=4ti2,bliss,build,cbc,ccache,cmake,cryptominisat,dochtml,dot2tex,e_antic,glucose,latte_int,lidia,lrslib,memlimit,mpir,ninja_build,normaliz,notedown,pandoc_attributes,pycosat,pynormaliz,python2,qhull,rst2ipynb,sage,topcom
Doctesting 1 file.
sage -t --long src/sage/geometry/polyhedron/backend_normaliz.py
**********************************************************************
File "src/sage/geometry/polyhedron/backend_normaliz.py", line 186, in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._nmz_result
Failed example:
    p._nmz_result(p._normaliz_cone, 'EquivariantXyzzyModuleSeries')  # optional - pynormaliz
Expected:
    Traceback (most recent call last):
    ...
    error: Some error in the normaliz input data detected: Unknown ConeProperty...
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 671, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1095, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._nmz_result[1]>", line 1, in <module>
        p._nmz_result(p._normaliz_cone, 'EquivariantXyzzyModuleSeries')  # optional - pynormaliz
      File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-packages/sage/geometry/polyhedron/backend_normaliz.py", line 192, in _nmz_result
        return PyNormaliz.NmzResult(normaliz_cone, property)
    NormalizError: Some error in the normaliz input data detected: Unknown ConeProperty string "EquivariantXyzzyModuleSeries"
**********************************************************************
1 item had failures:
   1 of   3 in sage.geometry.polyhedron.backend_normaliz.Polyhedron_normaliz._nmz_result
    [136 tests, 1 failure, 0.52 s]
----------------------------------------------------------------------
sage -t --long src/sage/geometry/polyhedron/backend_normaliz.py  # 1 doctest failed
----------------------------------------------------------------------

Change History (7)

comment:1 Changed 2 years ago by slabbe

  • Authors set to jipilab

comment:2 Changed 2 years ago by mkoeppe

  • Authors jipilab deleted
  • Cc jipilab added

comment:3 Changed 2 years ago by mkoeppe

  • Branch set to u/mkoeppe/1_pynormaliz_doctest_failing_in_src_sage_geometry_polyhedron_backend_normaliz_py

comment:4 Changed 2 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 9b3a5baab1c7c4144ce9d420d36278f3cb53e7d1
  • Status changed from new to needs_review

New commits:

9b3a5baFix error message in doctest for new pynormaliz version

comment:5 Changed 2 years ago by vklein

  • Reviewers set to Vincent Klein
  • Status changed from needs_review to positive_review

Looks good to me.

comment:6 Changed 2 years ago by mkoeppe

Thank you!

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/mkoeppe/1_pynormaliz_doctest_failing_in_src_sage_geometry_polyhedron_backend_normaliz_py to 9b3a5baab1c7c4144ce9d420d36278f3cb53e7d1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.