Opened 5 months ago

Last modified 4 days ago

#27780 positive_review defect

_flint_rep_abs of zero causes segmentation fault

Reported by: gh-oriparzan Owned by:
Priority: major Milestone: sage-8.9
Component: padics Keywords: padic extension flint, padicBordeaux
Cc: Merged in:
Authors: David Roe Reviewers: Travis Scrimshaw, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: u/roed/27780_flint_rep_abs (Commits) Commit: bbe334918d6e27839269c5644fe87970c248bed3
Dependencies: Stopgaps:

Description

On version 8.7. For a p-adic extension, _flint_rep_abs of zero breaks sage:

sage: F=Qp(2)
sage: L.<w> = F.ext(x^2+x+1)
sage: L(0)._flint_rep_abs()
sig_error() without sig_on()
------------------------------------------------------------------------
/home/parzan/sage-8.7/local/lib/python2.7/site-packages/cysignals/signals.so(+0x759b)[0x7fdd7629859b]
/home/parzan/sage-8.7/local/lib/python2.7/site-packages/cysignals/signals.so(+0x7658)[0x7fdd76298658]
/home/parzan/sage-8.7/local/lib/python2.7/site-packages/cysignals/signals.so(+0xa1a5)[0x7fdd7629b1a5]
/lib/x86_64-linux-gnu/libc.so.6(+0x3ef20)[0x7fdd85cf0f20]
/lib/x86_64-linux-gnu/libc.so.6(kill+0x7)[0x7fdd85cf1187]
/home/parzan/sage-8.7/local/lib/python2.7/site-packages/sage/ext/memory.so(+0x2e46)[0x7fd57aacbe46]
/home/parzan/sage-8.7/local/lib/libgmp.so.23(__gmpz_realloc+0x31)[0x7fdd7d50c7f1]
/home/parzan/sage-8.7/local/lib/libgmp.so.23(__gmpz_n_pow_ui+0x77e)[0x7fdd7d508e6e]
/home/parzan/sage-8.7/local/lib/libflint.so.13(fmpz_pow_ui+0xab)[0x7fdd6b21dcdb]
/home/parzan/sage-8.7/local/lib/python2.7/site-packages/sage/rings/padics/pow_computer_flint.so(+0x7c4e)[0x7fd56ba56c4e]
/home/parzan/sage-8.7/local/lib/python2.7/site-packages/sage/rings/padics/qadic_flint_CR.so(+0x19fe7)[0x7fd56acd1fe7]
/home/parzan/sage-8.7/local/lib/python2.7/site-packages/sage/rings/padics/qadic_flint_CR.so(+0x2d1a1)[0x7fd56ace51a1]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x7f11)[0x7fdd861b51e1]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7b8)[0x7fdd861b6f98]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCode+0x19)[0x7fdd861b71a9]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x68b6)[0x7fdd861b3b86]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7b8)[0x7fdd861b6f98]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x6713)[0x7fdd861b39e3]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7b8)[0x7fdd861b6f98]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x6713)[0x7fdd861b39e3]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7b8)[0x7fdd861b6f98]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x6713)[0x7fdd861b39e3]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7b8)[0x7fdd861b6f98]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x6713)[0x7fdd861b39e3]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7b8)[0x7fdd861b6f98]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x6713)[0x7fdd861b39e3]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7b8)[0x7fdd861b6f98]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x6713)[0x7fdd861b39e3]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7b8)[0x7fdd861b6f98]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyEval_EvalCode+0x19)[0x7fdd861b71a9]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyRun_FileExFlags+0x8a)[0x7fdd861d9eda]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(PyRun_SimpleFileExFlags+0xf1)[0x7fdd861dbe21]
/home/parzan/sage-8.7/local/lib/libpython2.7.so.1.0(Py_Main+0xb78)[0x7fdd861f5118]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7fdd85cd3b97]
/home/parzan/sage-8.7/local/bin/python2(_start+0x2a)[0x55c630c7677a]
------------------------------------------------------------------------
Attaching gdb to process id 14681.

Change History (13)

comment:1 Changed 3 months ago by embray

  • Milestone sage-8.8 deleted

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

comment:2 Changed 11 days ago by roed

  • Keywords padicBordeaux added

comment:3 Changed 6 days ago by roed

  • Branch set to u/roed/27780_flint_rep_abs

comment:4 Changed 6 days ago by roed

  • Authors set to David Roe
  • Branch u/roed/27780_flint_rep_abs deleted
  • Status changed from new to needs_review

comment:5 Changed 6 days ago by roed

  • Branch set to u/roed/27780_flint_rep_abs
  • Commit set to 6b466f1d3d065ba9c86e2d7e374139ec7127d031

New commits:

6b466f1Fix segfault

comment:6 Changed 6 days ago by tscrim

  • Reviewers set to Travis Scrimshaw

Minor nitpick, but we (generally try to) follow the Python convention of error messages starting with a lowercase letter. Once changed, you can set a positive review on my behalf.

comment:7 Changed 5 days ago by git

  • Commit changed from 6b466f1d3d065ba9c86e2d7e374139ec7127d031 to 47ec10ba15ede9d667a5daf6a8372642d1ebb15c

Branch pushed to git repo; I updated commit sha1. New commits:

47ec10bCapitalization

comment:8 Changed 5 days ago by roed

  • Status changed from needs_review to positive_review

Thanks!

comment:9 Changed 5 days ago by chapoton

  • Milestone set to sage-8.9

missing milestone added

comment:10 Changed 5 days ago by chapoton

  • Status changed from positive_review to needs_work

and the doctest will not pass (capital Z)

comment:11 Changed 5 days ago by git

  • Commit changed from 47ec10ba15ede9d667a5daf6a8372642d1ebb15c to bbe334918d6e27839269c5644fe87970c248bed3

Branch pushed to git repo; I updated commit sha1. New commits:

bbe3349Fix doctest

comment:12 Changed 5 days ago by roed

  • Status changed from needs_work to needs_review

Oops! I'll let the patchbot run.

comment:13 Changed 4 days ago by chapoton

  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

Note: See TracTickets for help on using tickets.