Opened 5 months ago

Closed 5 months ago

#27776 closed enhancement (fixed)

some py3 fixes in ext

Reported by: jhpalmieri Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: 3617562 (Commits) Commit: 3617562c0ed1959ca893d04f223dbc8016dc05af
Dependencies: Stopgaps:

Description

As the summary says.

Change History (5)

comment:1 Changed 5 months ago by jhpalmieri

  • Branch set to u/jhpalmieri/ext

comment:2 Changed 5 months ago by jhpalmieri

  • Commit set to 3617562c0ed1959ca893d04f223dbc8016dc05af
  • Status changed from new to needs_review

New commits:

​3617562trac 27776: fix py3 doctests in src/sage/ext.

comment:3 Changed 5 months ago by jhpalmieri

One py3 error remains: 

sage -t --long src/sage/ext/fast_callable.pyx
**********************************************************************
File "src/sage/ext/fast_callable.pyx", line 247, in sage.ext.fast_callable
Failed example:
    v4 = etb.choice(v3 >= etb.constant(0), v1, v2)
Exception raised:
    Traceback (most recent call last):
      File "/Users/palmieri/Desktop/Sage_stuff/sage_builds/PYTHON3/sage-8.8.beta4/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 671, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/palmieri/Desktop/Sage_stuff/sage_builds/PYTHON3/sage-8.8.beta4/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1095, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.ext.fast_callable[53]>", line 1, in <module>
        v4 = etb.choice(v3 >= etb.constant(Integer(0)), v1, v2)
    TypeError: '>=' not supported between instances of 'sage.ext.fast_callable.ExpressionCall' and 'sage.ext.fast_callable.ExpressionConstant'
**********************************************************************
1 item had failures:
   1 of  64 in sage.ext.fast_callable
    [614 tests, 1 failure, 1.95 s]

comment:4 Changed 5 months ago by vklein

  • Reviewers set to Vincent Klein
  • Status changed from needs_review to positive_review

Looks good to me.

comment:5 Changed 5 months ago by vbraun

  • Branch changed from u/jhpalmieri/ext to 3617562c0ed1959ca893d04f223dbc8016dc05af
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.