Opened 4 months ago

Closed 3 months ago

#27772 closed enhancement (fixed)

py3: fix some doctests in ppl lattice polytopes

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: jipilab, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 903a71e (Commits) Commit: 903a71e3234dc4b8a9747f66b723185e7f765dbf
Dependencies: Stopgaps:

Description

in a method about orbit representatives

Change History (8)

comment:1 Changed 4 months ago by chapoton

  • Branch set to u/chapoton/27772
  • Commit set to 9d3e54153458c1b869a0eaaa46175b9362c1f8a4
  • Status changed from new to needs_review

New commits:

9d3e541py3: fix some doctests in orbit representatives of polytopes vertex sets

comment:2 Changed 4 months ago by chapoton

  • Status changed from needs_review to needs_work

comment:3 Changed 3 months ago by chapoton

failing doctest in sage -t --long src/sage/geometry/polyhedron/ppl_lattice_polytope.py

comment:4 Changed 3 months ago by git

  • Commit changed from 9d3e54153458c1b869a0eaaa46175b9362c1f8a4 to 903a71e3234dc4b8a9747f66b723185e7f765dbf

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

903a71epy3: fix some doctests in orbit representatives of polytopes vertex sets

comment:5 Changed 3 months ago by chapoton

  • Status changed from needs_work to needs_review

comment:6 Changed 3 months ago by chapoton

  • Cc tscrim added

green bot, please review

comment:7 Changed 3 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

All this sorting feels a little heavy handed to get the doctests to pass, but I guess it should be insignificant compared to the main computation time.

comment:8 Changed 3 months ago by vbraun

  • Branch changed from u/chapoton/27772 to 903a71e3234dc4b8a9747f66b723185e7f765dbf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.