Opened 2 years ago

Closed 2 years ago

#27771 closed enhancement (fixed)

py3: matroid/unpickling.pyx fix

Reported by: jhpalmieri Owned by:
Priority: minor Milestone: sage-8.8
Component: python3 Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: cc0d4e3 (Commits, GitHub, GitLab) Commit: cc0d4e31b81fb3f25de17ded5fb38af3c2557b11
Dependencies: Stopgaps:

Status badges

Description

Convert a string to type bytes.

Change History (5)

comment:1 Changed 2 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/matroid-unpickling

comment:2 Changed 2 years ago by jhpalmieri

  • Commit set to cc0d4e31b81fb3f25de17ded5fb38af3c2557b11
  • Status changed from new to needs_review

New commits:

​cc0d4e3trac 27771: py3 fix for doctest in matroids/unpickling.pyx

comment:3 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton

works on python3. If you checked on py2, you can set a positive review.

comment:4 Changed 2 years ago by jhpalmieri

  • Status changed from needs_review to positive_review

In Python 2, a b prefix doesn't do anything, so this works the same in Python 2 as it did before.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/jhpalmieri/matroid-unpickling to cc0d4e31b81fb3f25de17ded5fb38af3c2557b11
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.