Opened 3 years ago

Closed 3 years ago

#27768 closed enhancement (fixed)

py3: fix a flaky doctest in multipoly element

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: tscrim, vdelecroix Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0db6b0d (Commits, GitHub, GitLab) Commit: 0db6b0d97f43c7ac4b0ce6b691dda46a3eb83f02
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

by refactoring a function.

This is strangely in the global namespace. Can we nevertheless change the behaviour by only returning the first output ?

Change History (3)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27768
  • Cc tscrim vdelecroix added
  • Commit set to 0db6b0d97f43c7ac4b0ce6b691dda46a3eb83f02
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​0db6b0dpy3: fix a doctest in multi_polynomial_element (refactoring)

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Since this is not causing any doctests to fail, it seems like it was not being used in the library code. Hopefully nothing breaks in the wild, but it is a strange little function...

comment:3 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27768 to 0db6b0d97f43c7ac4b0ce6b691dda46a3eb83f02
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.