Opened 2 years ago
Closed 2 years ago
#27767 closed enhancement (fixed)
py3: fix regression in qqbar.py
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.8 
Component:  python3  Keywords:  
Cc:  vdelecroix, tscrim  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  John Palmieri, JeanPhilippe Labbé 
Report Upstream:  N/A  Work issues:  
Branch:  55cbd22 (Commits, GitHub, GitLab)  Commit:  55cbd22e5cf3d184d9d65f826dad926a9e1e5eac 
Dependencies:  Stopgaps: 
Description (last modified by )
wrong use of map from #20181
Change History (8)
comment:1 Changed 2 years ago by
 Branch set to u/chapoton/27767
 Commit set to 70bef8eab0fccd917360187629f1212b1680e889
comment:2 Changed 2 years ago by
 Status changed from new to needs_review
comment:3 Changed 2 years ago by
 Description modified (diff)
comment:4 Changed 2 years ago by
Would this change be better? Do we want to discourage the use of map
when we want to get a list as a result?

src/sage/rings/qqbar.py
diff git a/src/sage/rings/qqbar.py b/src/sage/rings/qqbar.py index b582dd7a77..37640f5b34 100644
a b def number_field_elements_from_algebraics(numbers, minimal=False, same_field=Fal 2278 2278 2279 2279 # embeds the numbers 2280 2280 inter_hom = fld.hom([embedded_field.gen(0)]) 2281 nums = map(inter_hom, nums)2281 nums = [inter_hom(n) for n in nums] 2282 2282 2283 2283 # get the field and homomorphism 2284 2284 hom = embedded_field.hom([gen.root_as_algebraic()])
comment:5 Changed 2 years ago by
 Commit changed from 70bef8eab0fccd917360187629f1212b1680e889 to 55cbd22e5cf3d184d9d65f826dad926a9e1e5eac
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
55cbd22  fix py3 regression in qqbar.py

comment:6 Changed 2 years ago by
done, thx
comment:7 Changed 2 years ago by
 Reviewers set to John Palmieri, JeanPhilippe Labbé
 Status changed from needs_review to positive_review
Sorry for my mistake. Thanks for detecting this.
I take this as a signal to switch to python3 to develop...
comment:8 Changed 2 years ago by
 Branch changed from u/chapoton/27767 to 55cbd22e5cf3d184d9d65f826dad926a9e1e5eac
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
fix py3 regression in qqbar.py