#27759 closed defect (fixed)

cleanup pyflakes warnings in sage.rings.asymptotic

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-8.8
Component: asymptotic expansions Keywords:
Cc: behackl Merged in:
Authors: Daniel Krenn Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: d2deb26 (Commits) Commit: d2deb26a5a7a7b5eb7e0e1326f64adc4cd1be92d
Dependencies: Stopgaps:

Description

There are a couple of warnings in sage.rings.asymptotic reported by pyflakes.

(This might be seen as a follow up of https://trac.sagemath.org/ticket/26682#comment:10)

Change History (6)

comment:1 Changed 13 months ago by dkrenn

  • Branch set to u/dkrenn/asy-fix-pyflakes

comment:2 Changed 13 months ago by dkrenn

  • Commit set to d2deb26a5a7a7b5eb7e0e1326f64adc4cd1be92d
  • Status changed from new to needs_review
  • pyflakes warnings cleaned up. (Interestingly, the corresponding code/lines do not seem to be changed by the series of tickets ending with #26682, but the diff of the pyflakes output indicates they are not; not sure why this is so; maybe does not matter.)
  • There is
    src/sage/rings/asymptotic/growth_group.py:2260: undefined name 'CartesianProductGrowthGroups'
    
    does not seem to be cleanup-able as this comes from a lazy import (so it actually is imported as should).

So, let's see what the patchbot says now ;)


New commits:

8fee7c6Trac #27759: fix pyflakes import warning
d2deb26Trac #27759: remove unnecessary imports

comment:3 Changed 13 months ago by dkrenn

  • Cc behackl added

comment:4 Changed 13 months ago by chapoton

recent patchbots are able to detect the lazy imports.

comment:5 Changed 13 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:6 Changed 13 months ago by vbraun

  • Branch changed from u/dkrenn/asy-fix-pyflakes to d2deb26a5a7a7b5eb7e0e1326f64adc4cd1be92d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.