Opened 2 years ago
Closed 2 years ago
#27757 closed enhancement (fixed)
py3: remaining fixes in categories
| Reported by: | jhpalmieri | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-8.8 |
| Component: | python3 | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | John Palmieri | Reviewers: | Vincent Klein |
| Report Upstream: | N/A | Work issues: | |
| Branch: | a559d41 (Commits, GitHub, GitLab) | Commit: | a559d41cf523b4f35669900940541b006147776d |
| Dependencies: | Stopgaps: |
Status badges
Description
As the summary says...
Change History (5)
comment:1 Changed 2 years ago by
- Branch set to u/jhpalmieri/py3-categories
comment:2 Changed 2 years ago by
- Commit set to a559d41cf523b4f35669900940541b006147776d
- Status changed from new to needs_review
comment:3 Changed 2 years ago by
comment:4 Changed 2 years ago by
- Reviewers set to Vincent Klein
- Status changed from needs_review to positive_review
Looks good to me.
comment:5 Changed 2 years ago by
- Branch changed from u/jhpalmieri/py3-categories to a559d41cf523b4f35669900940541b006147776d
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
For some of these tests, ordering is random with Python 3: repeated runs produce different results. As now noted in the file, two doctests in
additive_magmas.pydon't actually test the relevant methods, but I don't know enough about the code to find good tests. For the changes inmap.pyx, after evaluating something like[x**2 for x in range(10)], in Python 2xwill be defined as 9, while in Python 3 it won't be defined, or if it was defined before, it retains its previous definition. So we don't needdel xin Python 3.New commits:
trac 27757: fix py3 doctests in categories.