#27746 closed defect (fixed)

Upgrade LiDIA to v2.3.0+latte-patches-2019-05-01

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-8.8
Component: packages: experimental Keywords:
Cc: dimpase, jipilab, gh-sophiasage Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: ba3e3e3 (Commits) Commit: ba3e3e34f72da8812da763589e700107aa810d73
Dependencies: Stopgaps:

Description (last modified by mkoeppe)

This upgrade fixes compile errors on Mac with clang 6.0.1 as reported here: https://groups.google.com/d/msg/sage-devel/UtdbqZy-1VE/Jlxfj3FxDAAJ as well as clang 7.

Upstream issues: https://github.com/mkoeppe/LiDIA/issues/1

Package:

wget -P upstream https://github.com/mkoeppe/LiDIA/releases/download/v2.3.0%2Blatte-patches-2019-05-02/lidia-2.3.0+latte-patches-2019-05-02.tar.gz

Attachments (2)

lidia-2.3.0+latte-patches-2014-10-04.p0.log (2.5 KB) - added by selia 11 months ago.
lidia-2.3.0+latte-patches-2019-05-01.log (2.5 KB) - added by selia 11 months ago.

Download all attachments as: .zip

Change History (26)

comment:1 Changed 11 months ago by dimpase

Also, https://github.com/mkoeppe/LiDIA/pull/2 - can this be merged upstream?

comment:2 Changed 11 months ago by jipilab

  • Component changed from PLEASE CHANGE to packages: experimental

comment:3 Changed 11 months ago by mkoeppe

What happened in this bug report is that CXX has been set to "g++ -std=gnu++11" (where g++ is the system's clang compiler). This causes an error.

comment:4 Changed 11 months ago by mkoeppe

  • Description modified (diff)
  • Report Upstream changed from Reported upstream. Developers acknowledge bug. to Fixed upstream, in a later stable release.
  • Summary changed from Fix LiDIA installation on macOS to Upgrade LiDIA to v2.3.0+latte-patches-2019-05-01

comment:5 Changed 11 months ago by mkoeppe

  • Branch set to u/mkoeppe/upgrade_lidia_to_v2_3_0_latte_patches_2019_05_01

comment:6 Changed 11 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to d0d3954bc46f03c253e96c16891984639c1d6fe1
  • Status changed from new to needs_review

New commits:

d0d3954Upgrade LiDIA to 2.3.0+latte-patches-2019-05-01

comment:7 Changed 11 months ago by dimpase

OK, this also needs adjustement w.r.t. to #27212. (Somehow lidia went under the radar there).

What is the correct way to configure it if GMP is installed in the standard location, searched by default by compiler/linker? Does it still need these --with-extra...?

Otherwise, spkg-install should contain something like

sdh_configure --with-arithmetic=gmp \
              --with-extra-includes="$SAGE_GMP_INCLUDE" \
              --with-extra-libs="$SAGE_GMP_PREFIX/lib" \
              --enable-shared=yes --enable-static=no

ok, so an experiment tells me that --with-extra- may be skipped if the GMP location is searched by compiler/linker.

Last edited 11 months ago by dimpase (previous) (diff)

comment:8 Changed 11 months ago by dimpase

otherwise, I checked that things build with gcc 8.3 on linux and with clang 6.0.1 on freebsd.

comment:9 Changed 11 months ago by git

  • Commit changed from d0d3954bc46f03c253e96c16891984639c1d6fe1 to 625a1e303618fcaebf41a0d1267edea1467dba91

Branch pushed to git repo; I updated commit sha1. New commits:

625a1e3build/pkgs/lidia/spkg-install: Use

comment:10 Changed 11 months ago by dimpase

in the setting where location of GMP headers and libs has to be specified in C(XX)FLAGS and in LDFLAGS, lidia's configure returns a false negative, as it ignores them for no good reason. So one needs

  • new file uild/pkgs/lidia/patches/accept_gmp.patch

    - +  
     1diff --git a/configure b/configure
     2index dd9b0ad..77a438a 100755
     3--- a/configure
     4+++ b/configure
     5@@ -18092,7 +18092,7 @@ EOF
     6   test $ac_status = 0; }; } > /dev/null 2>&1; then
     7                       lidia_cv_gmp="yes"
     8               else
     9-                      lidia_cv_gmp="no"
     10+                      lidia_cv_gmp="yes"
     11               fi
     12 
     13 fi

to tell it to shut up and trust that Sage has it all sorted already.

comment:11 Changed 11 months ago by mkoeppe

The correct fix, of course, would be in lidia's acinclude.m4.

comment:12 Changed 11 months ago by dimpase

Of course, but I saw way too many semi-broken homegrown m4 macros to recognise GMP lately to be bothered about it.

The only harm of this patch is that, potentially, if something goes horribly wrong, you get a linker error...

comment:13 Changed 11 months ago by dimpase

Changed 3 hours ago by selia
Attachment lidia-2.3.0+latte-patches-2014-10-04.p0.log​ added
Changed 3 hours ago by selia
Attachment lidia-2.3.0+latte-patches-2019-05-01.log​ added

@selia, have you pulled the branch of this ticket? There should not be any patches to apply in build/pkgs/lidia/patches/.

comment:14 Changed 11 months ago by mkoeppe

Dima, could you test branch config_flags from https://github.com/mkoeppe/LiDIA/tree/config_flags

comment:15 follow-up: Changed 11 months ago by dimpase

running ./bootstrap gives a lot of warnings like

library/number_fields/Makefile.am:42: warning: source file '$(LIDIA_NF_SRCDIR)/quadratic_order/quadratic_order1.cc' is in a subdirectory,
library/number_fields/Makefile.am:42: but option 'subdir-objects' is disabled

Is it normal?

comment:16 Changed 11 months ago by dimpase

OK, https://github.com/mkoeppe/LiDIA/tree/config_flags works for me in instead of the patch in comment:10.

By the way, not only with clang 6, but with clang 7 too.

comment:17 Changed 11 months ago by mkoeppe

Thanks for testing!

comment:18 Changed 11 months ago by dimpase

  • Reviewers set to Dima Pasechnik

once you made a new tarball, and provided a link to it, please feel free to set this to positive review.

comment:19 Changed 11 months ago by mkoeppe

  • Description modified (diff)

comment:20 Changed 11 months ago by mkoeppe

  • Description modified (diff)

comment:21 in reply to: ↑ 15 Changed 11 months ago by mkoeppe

Replying to dimpase:

running ./bootstrap gives a lot of warnings like

library/number_fields/Makefile.am:42: warning: source file '$(LIDIA_NF_SRCDIR)/quadratic_order/quadratic_order1.cc' is in a subdirectory,
library/number_fields/Makefile.am:42: but option 'subdir-objects' is disabled

Is it normal?

I see these warnings too, but I decided not to address them at this time.

comment:22 Changed 11 months ago by git

  • Commit changed from 625a1e303618fcaebf41a0d1267edea1467dba91 to ba3e3e34f72da8812da763589e700107aa810d73

Branch pushed to git repo; I updated commit sha1. New commits:

ba3e3e3Update LiDIA to 2.3.0+latte-patches-2019-05-02

comment:23 Changed 11 months ago by mkoeppe

  • Status changed from needs_review to positive_review

comment:24 Changed 11 months ago by vbraun

  • Branch changed from u/mkoeppe/upgrade_lidia_to_v2_3_0_latte_patches_2019_05_01 to ba3e3e34f72da8812da763589e700107aa810d73
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.