Opened 7 months ago

Closed 7 months ago

#27732 closed enhancement (fixed)

py3: fix one doctest in semigroups category

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: tscrim, jmantysalo, vklein Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: a21baee (Commits) Commit: a21baee0846dedfb9a2f1e5fe742f3b3309ef269
Dependencies: Stopgaps:

Description


Change History (10)

comment:1 Changed 7 months ago by chapoton

  • Branch set to u/chapoton/27732
  • Commit set to 1b90f5a736653677396290119eea12fb6847c031
  • Status changed from new to needs_review

New commits:

1b90f5apy3: fix one doctest in f-g-semigroups

comment:2 Changed 7 months ago by chapoton

  • Cc tscrim jmantysalo vklein added

green bot, please review

comment:3 Changed 7 months ago by tscrim

Why do you get only the first 9 elements instead of all of some_elements()?

comment:4 Changed 7 months ago by chapoton

Because the 10th one is not the same in py2 and py3.. something like xzy versus xyz..

comment:5 Changed 7 months ago by tscrim

This is again because RecursivelyEnumeratedSet gives different output order on the different Python versions. :/ It will work for those 9 elements since it iterates by length of the elements. Perhaps the better test(s) is

sage: X = S.some_elements()
sage: len(X)
10
sage: all(x in S for x in X)
True

comment:6 Changed 7 months ago by git

  • Commit changed from 1b90f5a736653677396290119eea12fb6847c031 to a21baee0846dedfb9a2f1e5fe742f3b3309ef269

Branch pushed to git repo; I updated commit sha1. New commits:

a21baeetrac 27732 change the doctest

comment:7 Changed 7 months ago by chapoton

ok, done

comment:8 Changed 7 months ago by chapoton

green bot

comment:9 Changed 7 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Sorry, I lost track of this. LGTM.

comment:10 Changed 7 months ago by vbraun

  • Branch changed from u/chapoton/27732 to a21baee0846dedfb9a2f1e5fe742f3b3309ef269
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.