Opened 3 years ago
Closed 3 years ago
#27732 closed enhancement (fixed)
py3: fix one doctest in semigroups category
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.8 
Component:  python3  Keywords:  
Cc:  tscrim, jmantysalo, vklein  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  a21baee (Commits, GitHub, GitLab)  Commit:  a21baee0846dedfb9a2f1e5fe742f3b3309ef269 
Dependencies:  Stopgaps: 
Description
Change History (10)
comment:1 Changed 3 years ago by
 Branch set to u/chapoton/27732
 Commit set to 1b90f5a736653677396290119eea12fb6847c031
 Status changed from new to needs_review
comment:3 Changed 3 years ago by
Why do you get only the first 9 elements instead of all of some_elements()
?
comment:4 Changed 3 years ago by
Because the 10th one is not the same in py2 and py3.. something like xzy versus xyz..
comment:5 Changed 3 years ago by
This is again because RecursivelyEnumeratedSet
gives different output order on the different Python versions. :/
It will work for those 9 elements since it iterates by length of the elements. Perhaps the better test(s) is
sage: X = S.some_elements() sage: len(X) 10 sage: all(x in S for x in X) True
comment:6 Changed 3 years ago by
 Commit changed from 1b90f5a736653677396290119eea12fb6847c031 to a21baee0846dedfb9a2f1e5fe742f3b3309ef269
Branch pushed to git repo; I updated commit sha1. New commits:
a21baee  trac 27732 change the doctest

comment:7 Changed 3 years ago by
ok, done
comment:8 Changed 3 years ago by
green bot
comment:9 Changed 3 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
Sorry, I lost track of this. LGTM.
comment:10 Changed 3 years ago by
 Branch changed from u/chapoton/27732 to a21baee0846dedfb9a2f1e5fe742f3b3309ef269
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
py3: fix one doctest in fgsemigroups