Opened 2 years ago

Last modified 2 years ago

#27731 closed defect

upgrade normaliz to 3.7.2, pynormaliz to 2.5 — at Version 13

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-8.8
Component: packages: optional Keywords:
Cc: Winfried, jipilab, gh-sebasguts, mkoeppe, vdelecroix, tscrim Merged in:
Authors: Matthias Koeppe Reviewers:
Report Upstream: N/A Work issues:
Branch: public/27731 (Commits, GitHub, GitLab) Commit: 5d013883725486cee52b7b247b8d0aab6d81f7d7
Dependencies: #27682 Stopgaps:

Status badges

Description (last modified by mkoeppe)

Another update of normaliz, pynormaliz. The upgrade of PyNormaliz from 2.1 to 2.5 fixes a critical data conversion bug (Check overflow for int conversion correctly) that was present in all previous versions.

Tarballs - see wget commands below.


Step by step instructions if you want to try it out

  1. Go to the Sage source tree and pull the branch associated to this ticket
  1. Get the tarballs and put them in the upstream repository
    $ wget -P upstream https://github.com/Normaliz/Normaliz/releases/download/v3.7.2/normaliz-3.7.2.tar.gz
    $ wget -P upstream https://files.pythonhosted.org/packages/31/8f/a1e8e489150a570c81b427d351a29b868df57015f13c12e8e6d2d2d55c45/PyNormaliz-2.5.tar.gz
    
  1. Compile and install everything
    $ sage -i pynormaliz
    
  1. Run make
    $ make build
    

Change History (13)

comment:1 Changed 2 years ago by mkoeppe

  • Dependencies set to #27682

comment:2 Changed 2 years ago by mkoeppe

  • Branch set to public/27731

comment:3 Changed 2 years ago by mkoeppe

  • Cc tscrim added
  • Commit set to 3d949a2219a3a502e3374ba68dd173bfa4acffcb
  • Status changed from new to needs_review

New commits:

eaa4584package e-antic 0.1.3b0
e5c669dupgrade normaliz
14d6c83Update normaliz to 3.7.1, pynormaliz to 2.1
64f1f19fix doctest in backend_normaliz.py
3d949a2Upgrade normaliz to 3.7.2, pynormaliz to 2.2

comment:4 Changed 2 years ago by vdelecroix

Hi,

What is the point of having several open tickets concerning Normaliz/PyNormaliz? upgrade? You want the job of the release manager to become a nightmare? If Normaliz/PyNormaliz? are not mature you should not have set anything to needs review in the first place. Also, you are shipping a beta version of e-antic which is not nice either.

comment:5 Changed 2 years ago by mkoeppe

3.7.1/2.1 are stable and an improvement over the existing versions in sage. The ticket #27682 is positively reviewed already, and per release manager, positively reviewed tickets are not to be modified further.

comment:6 Changed 2 years ago by vdelecroix

  • Status changed from needs_review to needs_work

PyNormaliz provides a test suite, there should be a spkg-check.

comment:7 Changed 2 years ago by git

  • Commit changed from 3d949a2219a3a502e3374ba68dd173bfa4acffcb to b4889111d4478b8dda2e15dac58a4d725cd2f0c0

Branch pushed to git repo; I updated commit sha1. New commits:

b488911Add build/pkgs/pynormaliz/spkg-check

comment:8 Changed 2 years ago by mkoeppe

PyNormaliz? test suite currently fails with the e-antic bug-fix release 0.1.3b0 that we have in #27682.

comment:9 Changed 2 years ago by mkoeppe

  • Description modified (diff)
  • Summary changed from upgrade normaliz to 3.7.2, pynormaliz to 2.2 to upgrade normaliz to 3.7.2, pynormaliz to 2.4

comment:10 Changed 2 years ago by git

  • Commit changed from b4889111d4478b8dda2e15dac58a4d725cd2f0c0 to 5d013883725486cee52b7b247b8d0aab6d81f7d7

Branch pushed to git repo; I updated commit sha1. New commits:

5d01388Upgrade pynormaliz to 2.4

comment:11 Changed 2 years ago by mkoeppe

  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Type changed from enhancement to defect

comment:12 Changed 2 years ago by mkoeppe

  • Description modified (diff)

comment:13 Changed 2 years ago by mkoeppe

  • Description modified (diff)
  • Summary changed from upgrade normaliz to 3.7.2, pynormaliz to 2.4 to upgrade normaliz to 3.7.2, pynormaliz to 2.5
Note: See TracTickets for help on using tickets.