Opened 6 months ago

Closed 6 months ago

#27727 closed enhancement (fixed)

py3: fix repr and iter for submultisets

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: tscrim, vklein Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: cd2950c (Commits) Commit: cd2950cee54c7357cd1f8bb84294414eb5288e50
Dependencies: Stopgaps:

Description

by changing slightly the internal data

This is needed to handle the difference in dict between py2 and py3

Change History (7)

comment:1 Changed 6 months ago by chapoton

  • Branch set to u/chapoton/27727
  • Commit set to c1c38d563004d4aa24e35845a9446509d04a723d
  • Status changed from new to needs_review

New commits:

c1c38d5py3: fix internal data, repr, iter of submultisets.

comment:2 Changed 6 months ago by git

  • Commit changed from c1c38d563004d4aa24e35845a9446509d04a723d to 2f7d2ddf932ba34585a8f4fbb75734a7ac6379ae

Branch pushed to git repo; I updated commit sha1. New commits:

2f7d2ddtrac 27727 fix

comment:3 Changed 6 months ago by chapoton

  • Cc tscrim vklein added

green bot, please review

comment:4 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

You seem to have over-indented in the book test. Even though it is not a multiple of 4, PEP8 says you should stick to the format in the file. Once fixed, you can set a positive review.

comment:5 Changed 6 months ago by git

  • Commit changed from 2f7d2ddf932ba34585a8f4fbb75734a7ac6379ae to cd2950cee54c7357cd1f8bb84294414eb5288e50

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cd2950cpy3: fix internal data, repr, iter of submultisets.

comment:6 Changed 6 months ago by chapoton

  • Status changed from needs_review to positive_review

thanks, done, setting to positive

comment:7 Changed 6 months ago by vbraun

  • Branch changed from u/chapoton/27727 to cd2950cee54c7357cd1f8bb84294414eb5288e50
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.